bugGnash - The GNU Flash player - Bugs: bug #19092, sound execute_tags are not...

 
 

bug #19092: sound execute_tags are not executed.

Submitted by:  Tomas Groth <tgc>
Submitted on:  Mon 19 Feb 2007 01:29:42 PM UTC  
 
Category: coreSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Tomas Groth <tgc>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 21 Feb 2007 02:58:35 PM UTC, comment #8:

Good. A testcase for the streaming case would be nice :)

Sandro Santilli <strk>
Project Member
Wed 21 Feb 2007 02:54:40 PM UTC, comment #7:

start_stream_sound_tag also needed to be a state tag, and is so now, and it all seems to be working now.
I fixed the test_sound_handler, and eventSoundTest1 now passes.

Tomas Groth <tgc>In charge of this item.
Wed 21 Feb 2007 08:34:00 AM UTC, comment #6:

About test runner not working, it seems started_all and stopped_all
members of the TESTsound_Handler are never incremented.
Rather, it only icrements and decrements playingSounds.

Sandro Santilli <strk>
Project Member
Wed 21 Feb 2007 08:20:28 AM UTC, comment #5:

It seems start_sound_tag must be considered a "state" tag,
not an "action" tag. So it has to define execute_state().
execute() if fine to call execute_state(), since execute()
is for executing things whatever they are.

I can hear the correct sound (only with mad, gst doesnt' work)
so I assume this fixed the thing. A couple of notes:

1) The test runner doesn't work (IMPORTANT TO FIX)

2) start_stream_sound_block likely needs the same threatment
(should be a state tag). I haven't touched it due to
lack of a testcase showing it broken.

Sandro Santilli <strk>
Project Member
Wed 21 Feb 2007 07:53:43 AM UTC, comment #4:

Mmm I don't see any STOPSOUND tag in the SWF looking for
it with Ming's 'listswf' utility. A Ming bug ?

Sandro Santilli <strk>
Project Member
Tue 20 Feb 2007 11:05:33 PM UTC, comment #3:

I think I found the problem. The execute_tags has been changed to a new way of executing: state vs. action. But execute_state() is defined empty (in execute_tags.h), so it never execute the tag. I tried just adding execute(m) in the body of execute_state(), and it did bring sound back, but the sound was started many times, not just once, so some checking is needed, probably something about displaylist as mentioned in the comments...

Tomas Groth <tgc>In charge of this item.
Tue 20 Feb 2007 05:48:31 PM UTC, comment #2:

Compare the ChangeLog file between the working and non-working versions to see what's changed between the two revision.

Sandro Santilli <strk>
Project Member
Tue 20 Feb 2007 04:39:23 PM UTC, comment #1:

A testcase has now been added (eventSoundTest1).
I tracked the problem down to between 20070212 and 20070213.

Tomas Groth <tgc>In charge of this item.
Mon 19 Feb 2007 01:29:42 PM UTC, original submission:

When playing any swf with sounds, gnash doesn't play the sounds. I've poked around a bit, but got lost in the source code... The problem seems to be that the execute_tags are not executed.

Tomas Groth <tgc>In charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by tgc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 21 Feb 2007 07:20:05 PM UTCtgcStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 21 Feb 2007 08:34:00 AM UTCstrkAssigned toNone=>tgc
    Wed 21 Feb 2007 08:20:28 AM UTCstrkStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1