bugPSPP - Bugs: bug #18922, Crashes if filenames differ only...

 
 

bug #18922: Crashes if filenames differ only in case.

Submitted by:  John Darrington <jmd>
Submitted on:  Thu 01 Feb 2007 03:59:20 AM UTC  
 
Category: Syntax ParserSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 02 Feb 2007 12:57:36 AM UTC, comment #3:

We believe that this problem is fixed in a change recently
checked into the CVS respository. If you discover that the bug
has not been fixed, please re-open the bug.

Thank you for your help in improving PSPP.

Ben Pfaff <blp>
Project Administrator
Fri 02 Feb 2007 12:26:01 AM UTC, comment #2:

works for me.

John Darrington <jmd>
Project Administrator
Thu 01 Feb 2007 05:42:29 PM UTC, comment #1:

The problem is that we're using a single member in struct file_handle, the "name" field, for more than one purpose. When it begins with '"', it's a file name; otherwise, it's a token that can be used to identify it. When that assertion fires, it's because we searched for the name case-sensitively as a file name (so that there was no match), and then we try to insert it case-insensitively as a token, which fails because duplicates aren't allowed.

Solution: break the two purposes into two separate fields. This fixes the problem and likely makes the code easier to read too.

Patch attached.

(file #11906)

Ben Pfaff <blp>
Project Administrator
Thu 01 Feb 2007 03:59:20 AM UTC, original submission:

This code causes an assertion failure. It works if the two filenames have the same orthography.

data list list /x *.
begin data.
1
2
3
4
end data.

save outfile 'data.sav'.

MATCH
FILES FILE='DATA.SAV'
/BY x.

LIST.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11906:  fh-crash.patch added by blp (9KiB - text/x-patch - fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Updated the item)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 02 Feb 2007 12:57:36 AM UTCblpStatusReady for Test/Review=>Fixed
      Open/ClosedOpen=>Closed
    Thu 01 Feb 2007 05:42:29 PM UTCblpAttached File-=>Added fh-crash.patch, #11906
      StatusNone=>Ready for Test/Review

    Back to the top


    Powered by Savane 3.1-cleanup1