bugGNU FreeIPMI - Bugs: bug #18733, bmc-info issue

 
 

bug #18733: bmc-info issue

Submitted by:  Albert Chu <chu11>
Submitted on:  Tue 09 Jan 2007 05:41:45 PM UTC  
 
Category: bmc-infoSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Albert Chu <chu11>Open/Closed: Closed
Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 09 Jan 2007 06:13:30 PM UTC, comment #1:

Looking at section 6.4 in the spec, I guess the == to channel_info_list
[i].protocol_type was forgotten. I'll add that.

Al

Albert Chu <chu11>
Project AdministratorIn charge of this item.
Tue 09 Jan 2007 05:41:45 PM UTC, original submission:

if (IPMI_CHANNEL_PROTOCOL_TYPE_IS_RESERVED(channel_info_list[i].protocol_type))
printf (" Protocol Type: %s\n", "Reserved");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_IPMB)
printf (" Protocol Type: %s\n", "IPMB-1.0");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_ICMB_10)
printf (" Protocol Type: %s\n", "ICMB-1.0");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_SMBUS_1X_2X)
printf (" Protocol Type: %s\n", "IPMI-SMBus");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_KCS)
printf (" Protocol Type: %s\n", "KCS");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_SMIC)
printf (" Protocol Type: %s\n", "SMIC");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_BT_10)
printf (" Protocol Type: %s\n", "BT-10");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_BT_15)
printf (" Protocol Type: %s\n", "BT-15");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_TMODE)
printf (" Protocol Type: %s\n", "TMODE");
else if (IPMI_CHANNEL_PROTOCOL_TYPE_IS_OEM(channel_info_list[i].protocol_type))
printf (" Protocol Type: %s\n", "OEM");

Most of the "else if" statements look wrong. I believe they have to be masked with something.

Albert Chu <chu11>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chu11 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 09 May 2007 06:36:08 AM UTCchu11StatusNone=>Fixed
      Assigned toNone=>chu11
    Tue 09 Jan 2007 06:13:30 PM UTCchu11Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1