bugPSPP - Bugs: bug #18705, Implement INSERT command.

 
 

bug #18705: Implement INSERT command.

Submitted by:  Ben Pfaff <blp>
Submitted on:  Fri 05 Jan 2007 11:27:09 PM UTC  
 
Category: Syntax ParserSeverity: 1 - Wishlist
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: Before 0.6.0
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 05 Sep 2007 06:24:34 AM UTC, comment #4:

Thanks.

I fixed these issues and checked it in.

John Darrington <jmd>
Project Administrator
Wed 05 Sep 2007 04:39:42 AM UTC, comment #3:

Thanks for making this work! It looks good. I have a bunch of mostly
editorial comments.

In the manual:

Could BATCH mode and INTERACTIVE mode simply be called batch and
interactive mode? I don't think that the capitals add any
clarification.

This line:

+Certain commands, such as @cmd{INSERT}, (@ref{INSERT}) may explicitly

I would write as:

+Certain commands, such as @cmd{INSERT} (@pxref{INSERT}), may explicitly

(Note the position of the comma and use of @pxref.)

It looks like we should remove the documentation that we support "@"
as a way to include syntax files. I think this is an SPSS/PC+-only
feature that SPSS does not have (early versions of PSPP targeted
SPSS/PC+ instead of SPSS), and thus I removed it from PSPP. It seems
that I missed the mention of it in the manual.

Could you add a cross-reference to INSERT from the INCLUDE node?

In the INSERT code, could you change (@ref{INCLUDE}) to
(@pxref{INCLUDE})?

In do_parse_command, I think that the change as written does not
completely make sense. The "goto"s that are inserted will only change
the effect of the function if they change "result" to CMD_FAILURE, but
none of them change it to CMD_FAILURE. Is that really what was
intended? Perhaps the "result = CMD_FINISH;" statements should be
"result = CMD_FAILURE;"? Or perhaps "if (result == CMD_FAILURE)"
should be "if (cmd_result_is_failure (result))"?

In cmd_insert, I would call lex_error in place of at least the final
call to msg, possibly other calls too although there are i18n issues
that need to be worked out for lex_error in those cases.

I'm happy with the rest.

Ben Pfaff <blp>
Project Administrator
Sat 01 Sep 2007 12:55:43 PM UTC, comment #2:

Here's a first stab at it.

(file #13860)

John Darrington <jmd>
Project Administrator
Fri 31 Aug 2007 08:10:15 AM UTC, comment #1:

I'm looking at this one.

John Darrington <jmd>
Project Administrator
Fri 05 Jan 2007 11:27:09 PM UTC, original submission:

SPSS has an INSERT command, similar to INCLUDE with a few more bells and whistles, that we should also implement.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13860:  insert.patch added by jmd (51KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 05 Sep 2007 06:24:34 AM UTCjmdStatusWorks For Me=>Fixed
      Assigned tojmd=>None
      Open/ClosedOpen=>Closed
    Wed 05 Sep 2007 04:39:42 AM UTCblpStatusReady for Test/Review=>Works For Me
    Sat 01 Sep 2007 12:55:43 PM UTCjmdStatusIn Progress=>Ready for Test/Review
    Sat 01 Sep 2007 12:55:42 PM UTCjmdAttached File-=>Added insert.patch, #13860
    Fri 31 Aug 2007 08:10:15 AM UTCjmdStatusNone=>In Progress
      Assigned toNone=>jmd
    Wed 25 Jul 2007 03:20:40 PM UTCblpReleaseNone=>Before 0.6.0

    Back to the top


    Powered by Savane 3.1-cleanup1