bugGnash - The GNU Flash player - Bugs: bug #18693, some binary files were not...

 
 

bug #18693: some binary files were not committed as binary format

Submitted by:  Zou Lunkai <zoulunkai>
Submitted on:  Fri 05 Jan 2007 01:17:54 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 21 Feb 2007 10:17:59 AM UTC, comment #5:

This should be the way to commit as binary:

$ cvs admin -kb kotest

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 08 Feb 2007 09:05:15 AM UTC, comment #4:

I could perform "make check" and haven't found any corrupt files for weeks. So, this may not be a problem for Gnash now.

Zou Lunkai <zoulunkai>
Thu 11 Jan 2007 09:53:04 AM UTC, comment #3:

Fixed. Set binary flags to .swf .png under 'samples' and 'movies.all' too.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 11 Jan 2007 09:19:03 AM UTC, comment #2:

detected more files need to be fixed:

testsuite/media/green.swf
testsuite/media/green.jpg
testsuite/media/lynch.jpg
testsuite/media/lynch.swf
testsuite/media/offspring.jpg
testsuite/media/offspring.swf

testsuite/samples/clip_as_button2.swf
testsuite/samples/gradient-tests.png

Zou Lunkai <zoulunkai>
Fri 05 Jan 2007 10:26:43 PM UTC, comment #1:

Got your file and yes, confirm it creates a malformed SWF.
Now Gnash is actually able to play it and you can see results with -v. You can also see the shapes, while the text is broken.
So it seems that with current Gnash the only corrupted character is the font character, and indeed you get warnings of this kind:

23:21:42: WARNING: void gnash::edit_text_character::format_text() -- missing glyph for char 99. Make sure character shapes for font Bitstream Vera Sans are being exported into your SWF file!

My guess is that in this case Gnash should be using device fonts
as a fallback. See task #5969.

As for this specific bug I fixed the 'binary' attribute for the font file. Feel free to add new comments when you discover other similar issues.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 05 Jan 2007 01:17:54 AM UTC, original submission:

Some binary files like *.swf were committed as text file, and this would cause serious problems in a certain case.

strk has fixed some files, but still more files need to be checked. This bug report may be used for logging such things.

For example, file "Bitstream Vera Sans.fdb" is in binary format, but it is probably committed as text file. When I checkout it from the CVS, it was actually corruptted because of sth. related to 'END LINE CONVERSION'.

Hey, strk.
It's not Ming_0.3's fault to produce the bogus place_and_remove_object_test.swf testcase. It was the fault of the corruptted "Bitstream Vera Sans.fdb" here. Although it is corruptted, it escaped from Ming's and MM player's check and successfully embedded into the 'DejagnuClip'. At last, it fails Gnash.

I attached the corruptted "Bitstream Vera Sans.fdb" to reproduce the bogus place_and_remove_object_test.swf testcase.

Zou Lunkai <zoulunkai>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11680:  Bitstream Vera Sans_corrupt.fdb added by zoulunkai (31KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by zoulunkai (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 08 Feb 2007 09:08:40 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 05 Jan 2007 10:26:43 PM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk
    Fri 05 Jan 2007 01:17:55 AM UTCzoulunkaiAttached File-=>Added Bitstream Vera Sans_corrupt.fdb, #11680

    Back to the top


    Powered by Savane 3.1-cleanup1