bugmake - Bugs: bug #18680, fix for bug#2846 does not work as...

 
 

bug #18680: fix for bug#2846 does not work as expected, still hang sometimes

Submitted by:  None
Submitted on:  Wed 03 Jan 2007 02:06:34 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.81Operating System: POSIX-Based
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Jan 2007 01:58:39 AM UTC, comment #1:

Doh! Silly. As a lame excuse I'll mention that the original fix was for situations where errno was not 0 before invoking the macro, not where it was set to 0 inside the macro. However it should have been obvious that the latter was necessary as well.

Fix applied.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Wed 03 Jan 2007 02:06:34 PM UTC, original submission:

The macro ENULLLOOP in make.h does not work as expected to be fixed in bug #2846.
If "_c" returns zero with errno=EINTR when called first, the inner while-loop repeats calling "_c", but without setting errno=0 before the next call.
So errno keeps being EINTR, while "_c" already succeeds, and make run into an endless loop.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11674:  make-3.81-eintr-loop.patch added by None (421B - text/x-patch - Patch for reworked ENULLLOOP macro)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:19:02 AM UTCpsmithFixed Release4.0=>3.82
    Thu 04 Jan 2007 01:58:39 AM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.0
    Wed 03 Jan 2007 02:06:34 PM UTCNoneAttached File-=>Added make-3.81-eintr-loop.patch, #11674

    Back to the top


    Powered by Savane 3.1-cleanup1