bugGnash - The GNU Flash player - Bugs: bug #18663, Required ffmpeg version should be...

 
 

bug #18663: Required ffmpeg version should be enforced

Submitted by:  Bastiaan Jacques <bjacques>
Submitted on:  Sun 31 Dec 2006 05:06:36 PM UTC  
 
Category: sound-sdlSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 21 Feb 2007 07:41:57 PM UTC, comment #11:

Confirmed fix. Compliments! :)

Sandro Santilli <strk>
Project Member
Wed 21 Feb 2007 07:19:51 PM UTC, comment #10:

Now i'm almost certain it works! (i hope anyway...)

Tomas Groth <tgc>
Wed 21 Feb 2007 03:10:26 PM UTC, comment #9:

Do we want it to abort? In theory we might support older versions... But anyway, configure should have printed an error, by i guess it didn't. I'll have another go at it.

Tomas Groth <tgc>
Wed 21 Feb 2007 03:04:49 PM UTC, comment #8:

Nope, configure doesn't abort yet:

config.log:

configure:20538: checking for ffmpeg header
configure:20712: result: -I/usr/include/ffmpeg

make dumpconfig:

FFMPEG_CFLAGS is -I/usr/include/ffmpeg
FFMPEG_LIBS is -lavcodec -ldts -lz -ldl -lvorbis -lm -ltheora -lavutil -logg -ldts -lavutil -lvorbisenc -lvorbis -lm -logg -lavformat -lavcodec -ldts -lz -ldl -lvorbis -lm -ltheora -lavutil -logg -ltheora -logg -ldc1394_control

make:

libbase/embedVideoDecoderFfmpeg.cpp:62: error: 'CODEC_ID_VP6F' was not declared in this scope

Sandro Santilli <strk>
Project Member
Wed 21 Feb 2007 02:55:08 PM UTC, comment #7:

I tried to fix it - again. please test.

Tomas Groth <tgc>
Wed 21 Feb 2007 07:17:38 AM UTC, comment #6:

Again, this is NOT fixed.
It will be fixed when ./configure will abort with this ffmpeg
version:
ii ffmpeg 0.cvs20050918-5ubuntu1.1

Here ./configure succeeds, but make fails with this message:

/home/strk/src/gnash/gnash-head/libbase/embedVideoDecoderFfmpeg.cpp:62: error: 'CODEC_ID_VP6F' was not declared in this scope
/home/strk/src/gnash/gnash-head/libbase/embedVideoDecoderFfmpeg.cpp:65: error: 'CODEC_ID_FLASHSV' was not declared in this scope

Sandro Santilli <strk>
Project Member
Tue 20 Feb 2007 11:08:41 PM UTC, comment #5:

#19042 and this should be fixed.

Tomas Groth <tgc>
Mon 12 Feb 2007 05:53:32 PM UTC, comment #4:

Doesn't work yet. See #19042.

Sandro Santilli <strk>
Project Member
Fri 09 Feb 2007 08:47:42 PM UTC, comment #3:

I added code that does this, let me know if it works for you.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 01 Jan 2007 04:38:23 PM UTC, comment #2:

Yes, that's what I meant when I wrote "build system".

Bastiaan Jacques <bjacques>
Project Member
Mon 01 Jan 2007 03:41:41 AM UTC, comment #1:

I suppose this should be checked when running configure, and not when compiling?

Happy New Year! :)

Tomas Groth <tgc>
Sun 31 Dec 2006 05:06:36 PM UTC, original submission:

When building sound support with ffmpeg, the minimum required version is LIBAVCODEC_BUILD 4756 (unfortunately, the ffmpeg people don't bother to put out regular releases, so we can't just require version 0.4.9-pre1). Our build system should bail out if we're dealing with a build number less than the required one.

The build number can be either extracted from the avcodec.h file, or from ffmpeg --version, AFAIK.

Bastiaan Jacques <bjacques>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by tgc (Posted a comment)
  • -unavailable- added by bjacques (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 21 Feb 2007 07:47:51 PM UTCtgcStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 21 Feb 2007 07:19:51 PM UTCtgcStatusConfirmed=>Ready For Test
    Wed 21 Feb 2007 03:10:26 PM UTCtgcStatusReady For Test=>Confirmed
    Wed 21 Feb 2007 02:55:08 PM UTCtgcStatusConfirmed=>Ready For Test
    Wed 21 Feb 2007 07:17:38 AM UTCstrkStatusFixed=>Confirmed
      Open/ClosedClosed=>Open
    Tue 20 Feb 2007 11:08:41 PM UTCtgcStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 09 Feb 2007 08:47:42 PM UTCrsavoyeStatusNone=>Ready For Test
      Assigned totgc=>rsavoye

    Back to the top


    Powered by Savane 3.1-cleanup1