bugmake - Bugs: bug #18622, regression cannot turn off...

 
 

bug #18622: regression cannot turn off implicit rules for %.c and %.tex in 3.81

Submitted by:  None
Submitted on:  Thu 28 Dec 2006 10:26:52 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.81Operating System: Any
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Sep 2009 02:46:04 AM UTC, comment #2:

Fixed during the rework of secondary expansion.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sat 13 Jun 2009 11:46:56 PM UTC, comment #1:

Ouch. This is a result of the secondary expansion feature. The problem is that we defer the tokenization of dependencies until the snap_deps() step, when all the makefiles have been read in. This means that when we try to override the pattern rule and compare the dependencies, they don't match because our "internal" dependencies are two separate strings "%.w" and "%.ch" (for example) but the overriding dependencies are (at this point) a single string "%.w %.ch". We don't split them until later.

There are actually a number of problems with the current secondary expansion feature, not least of which is that it wastes memory; I have a half-completed workspace that is changed to always split dependencies right away UNLESS we can show that secondary expansion is a possibility (that is that the .SECONDARYEXPANSION special target is present, AND that the prerequisite list contains expandable elements---contains one or more "$").

Once that change is completed, it will fix this bug as well.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
 Spam posted by an anonymous
Thu 28 Dec 2006 10:26:52 PM UTC, original submission:

makefile
--start--
all: fred

fred: foo

foo:
touch fred

#goal to get equivalent of gmake --no-builtin-rules functionality
.SUFFIXES:
#shutoff implicit rules
(%): %
%.out: %
%:: %,v
%:: RCS/%,v
%:: RCS/%
%:: s.%
%:: SCCS/s.%
%.c: %.w %.ch
%.tex: %.w %.ch
--end makefile--

repro steps:
gmake -p -f makefile.9 > file
in verbose output find section (about line 862)
that starts with # Implicit rules
defect is that the implicit rules for CTANGLE and CWEAVE are not disabled using gmake 3.81

output from gmake 3.81
...

# Implicit Rules

(%): %

%.out: %

%:: %,v

%:: RCS/%,v

%:: RCS/%

%:: s.%

%:: SCCS/s.%

%.c: %.w %.ch

%.tex: %.w %.ch

%.c: %.w %.ch
# commands to execute (built-in):
$(CTANGLE) $^ $@

%.tex: %.w %.ch
# commands to execute (built-in):
$(CWEAVE) $^ $@

# 11 implicit rules, 5 (45.5%) terminal.

--end output --
correct out from gmake 3.80
...
# Implicit Rules

(%): %

%.out: %

%:: %,v

%:: RCS/%,v

%:: RCS/%

%:: s.%

%:: SCCS/s.%

%.c: %.w %.ch

%.tex: %.w %.ch

# 9 implicit rules, 5 (55.6%) terminal.
--end 3.80 output--
gmake -v output
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-unknown-linux-gnu

for additional information contact -unavailable-

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11619:  makefile.9 added by None (241B - application/octet-stream - makefile.9 is attached )

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:19:06 AM UTCpsmithFixed Release4.0=>3.82
    Thu 24 Sep 2009 02:46:04 AM UTCpsmithFixed ReleaseNone=>4.0
      StatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
    Wed 09 Jul 2008 12:51:19 PM UTCpsmithAttached File#16075=>Removed
    Wed 09 Jul 2008 07:34:52 AM UTCNoneAttached File-=>Added feed_atom03_80x15.png, #16075
    Thu 28 Dec 2006 10:26:52 PM UTCNoneAttached File-=>Added makefile.9, #11619

    Back to the top


    Powered by Savane 3.1-cleanup1