bugPSPP - Bugs: bug #18533, RANK should allow string grouping...

 
 

bug #18533: RANK should allow string grouping variables

Submitted by:  Ben Pfaff <blp>
Submitted on:  Fri 15 Dec 2006 08:30:25 PM UTC  
 
Category: Syntax ParserSeverity: 5 - Average
Status: FixedAssigned to: Ben Pfaff <blp>
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 16 Dec 2006 08:57:30 PM UTC, comment #2:

We believe that this problem is fixed in a change recently
checked into the CVS respository. If you discover that the bug
has not been fixed, please re-open the bug.

Thank you for your help in improving PSPP.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sat 16 Dec 2006 08:29:48 AM UTC, comment #1:

I can't see any problems either.

John Darrington <jmd>
Project Administrator
Fri 15 Dec 2006 08:30:25 PM UTC, original submission:

I don't see a reason why grouping variables shouldn't be strings. This patch seems to be all that is needed:

--- rank.q.~1.21.~ 2006-12-09 21:37:26.000000000 -0800
+++ rank.q 2006-12-15 12:22:50.000000000 -0800
@@ -953,7 +954,7 @@ rank_custom_variables (struct lexer *lex

if (!parse_variables (lexer, dataset_dict (ds),
&group_vars, &n_group_vars,
- PV_NO_DUPLICATE | PV_NUMERIC | PV_NO_SCRATCH) )
+ PV_NO_DUPLICATE | PV_NO_SCRATCH) )
{
free (group_vars);
return 0;

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 16 Dec 2006 08:57:30 PM UTCblpStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 16 Dec 2006 08:29:48 AM UTCjmdAssigned tojmd=>blp

    Back to the top


    Powered by Savane 3.1-cleanup1