bugCompact Disc Input and Control Library - Bugs: bug #18522, typo in configure.ac

 
 

bug #18522: typo in configure.ac

Submitted by:  Gergely Szász <szaszg>
Submitted on:  Wed 13 Dec 2006 10:07:01 PM UTC  
 
Category: configurationSeverity: 5 - Average
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 30 Dec 2007 12:18:53 AM UTC, comment #3:

Current CVS sources (revision 1.3 from November 16, 2007) have this corrected.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Sat 29 Dec 2007 11:42:34 PM UTC, comment #2:

The utf8.c.diff patch has broken building of libcdio with ./configure --enable-joliet because the '#ifdef HAVE_JOLIET' conditionnal shoudln't be put at the beginning of the file, but after including config.h, where HAVE_JOLIET is defined.

Even Rouault <rouault>
Thu 14 Dec 2006 12:53:07 AM UTC, comment #1:

Thanks! Your patch has been applied in CVS.

Although Joliet right now is the only think using utf8.c it's possible that the situation may change in the future as more UDF support is added and which may use this.

Thanks again.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Wed 13 Dec 2006 10:07:01 PM UTC, original submission:

The next line in configure.ac:
if test "${enable_jolet}" != "no" ; then
AM_ICONV

should be:
if test "${enable_joliet}" != "no" ; then
AM_ICONV

and may surround lib/driver/utf8.c with '#ifdef HAVE_JOLIET'/'#endif' pair...

Gergely Szász <szaszg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11515:  configure.ac.diff added by szaszg (343B - text/x-patch - jolet to joliet)
file #11516:  utf8.c.diff added by szaszg (328B - text/x-patch - jolet to joliet)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rouault (Posted a comment)
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by szaszg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 14 Dec 2006 12:53:07 AM UTCrockyStatusNone=>Fixed
      Assigned toNone=>rocky
      Open/ClosedOpen=>Closed
    Wed 13 Dec 2006 10:07:01 PM UTCszaszgAttached File-=>Added configure.ac.diff, #11515
      Attached File-=>Added utf8.c.diff, #11516

    Back to the top


    Powered by Savane 3.1-cleanup1