bugGnash - The GNU Flash player - Bugs: bug #18425, SDL/agg only show a black window

 
 

bug #18425: SDL/agg only show a black window

Submitted by:  Sandro Santilli <strk>
Submitted on:  Thu 30 Nov 2006 08:40:58 PM UTC  
 
Category: gui-sdlSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Zou Lunkai <zoulunkai>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 22 Dec 2006 09:21:22 AM UTC, comment #10:

Works for me. Committed, thanks !

Sandro Santilli <strk>
Project Member
Fri 22 Dec 2006 07:33:23 AM UTC, comment #9:

I have attached a simple patch. It works for me. Can you confirm if it works there?

(file #11581)

Zou Lunkai <zoulunkai>In charge of this item.
Mon 18 Dec 2006 07:16:38 PM UTC, comment #8:

Well, I keep seing the black-window-only thing with head, so I confirm this.

Bastiaan, can you add to your long TODO list ? ;)

Sandro Santilli <strk>
Project Member
Fri 08 Dec 2006 01:55:13 PM UTC, comment #7:

cvs -z3 -d:pserver:anonymous@cvs.savannah.gnu.org:/sources/gnash co gnash

The above works fine for me. Make sure CVS_RSH is unset.

Sandro Santilli <strk>
Project Member
Fri 08 Dec 2006 12:56:30 AM UTC, comment #6:

I am sorry. I can not update my source from the anonymous cvs for weeks. I could access it before. I don't know why.

I have tried the instructions from https://savannah.gnu.org/cvs/?group=gnash
cvs -z3 -d:pserver:anonymous@cvs.savannah.gnu.org:/sources/gnash co gnash

and from http://www.gnu.org/software/gnash/
export CVS_RSH="ssh"
cvs -z3 -d:pserver:anonymous@cvs.sv.gnu.org:/sources/gnash co gnash

the server addresses are different. But I cann't update from both of them.

Yes, I could view the sources from the web repository. But it's too difficult to download all the files one by one:)

Zou Lunkai <zoulunkai>In charge of this item.
Thu 07 Dec 2006 09:53:44 AM UTC, comment #5:

Can you also try with current head ? I've applied your patch there IIRC.

Sandro Santilli <strk>
Project Member
Thu 07 Dec 2006 03:43:51 AM UTC, comment #4:

>>That change doesn't fix the bug here, does it do it there ?


Yes, I also tried the program under linux. After I initialized the xscale and yscale, the flash movie can play normally, otherwize a black window.

Zou Lunkai <zoulunkai>In charge of this item.
Sun 03 Dec 2006 07:48:49 AM UTC, comment #3:

Yes. But I am working on WindowsXP VC8.0 environment and gnash_release_0_7_2.

I will try the program under linux to see if it works.

Zou Lunkai <zoulunkai>In charge of this item.
Sat 02 Dec 2006 09:33:51 PM UTC, comment #2:

That change doesn't fix the bug here, does it do it there ?

Sandro Santilli <strk>
Project Member
Fri 01 Dec 2006 04:03:39 AM UTC, comment #1:

Confirm.

This is probabley because of the xscale and yscale intialization
problem.
//file render_handler_agg.cpp
render_handler_agg(int bits_per_pixel)
:
// Initialization list
memaddr(NULL),
memsize(0),
xres(1),
yres(1),
bpp(bits_per_pixel),
xscale(1.0), //should be xscale(1.0/20),
yscale(1.0), //should be yscale(1.0/20),
m_enable_antialias(true),
m_pixf(NULL)
{
}

the set_scale is as follows:
void set_scale(float new_xscale, float new_yscale) {
xscale = new_xscale/20.0f;
yscale = new_yscale/20.0f;
}

The xscale/yscale seems never initialized before you update the
render_handler_agg constructor. When I use the sdl/agg, I should
aways add an extra intialization. So I wonder dose it ever work:)

//file SDL.cpp
bool
SDLGui::init(int argc, char **argv[])
{
...

...
_glue.init(argc, argv);
_renderer = _glue.createRenderHandler(_depth);

//the scale should be intialized, is it proper to do it here?
_renderer->set_scale(1.0, 1.0); //init the scale

return true;
}

Zou Lunkai <zoulunkai>In charge of this item.
Thu 30 Nov 2006 08:40:58 PM UTC, original submission:

Haven't tried SDL/anything_else, anyway SDL/agg doesn't seem to work, only a black window is displaied.
This is with current CVS. Can anyone confirm ?

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by zoulunkai (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Apr 2007 09:43:51 AM UTCstrkStatusReady For Test=>Fixed
      Assigned toNone=>zoulunkai
      Open/ClosedOpen=>Closed
    Fri 22 Dec 2006 09:21:22 AM UTCstrkStatusConfirmed=>Ready For Test
    Fri 22 Dec 2006 07:33:23 AM UTCzoulunkaiAttached File-=>Added sdl_agg_glue-patch.txt, #11581
    Mon 18 Dec 2006 07:16:38 PM UTCstrkStatusNone=>Confirmed
      Carbon-Copy-=>Added bjacques

    Back to the top


    Powered by Savane 3.1-cleanup1