bugGnash - The GNU Flash player - Bugs: bug #18250, some 2.4 agg version are not...

 
 

bug #18250: some 2.4 agg version are not suitable for gnash

Submitted by:  Patrice Dumas <pertusus>
Submitted on:  Fri 10 Nov 2006 11:49:28 AM UTC  
 
Category: buildSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Markus Gothe <nihilus>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 16 Nov 2006 08:55:19 AM UTC, comment #7:

Ok, updated to use your suggested message.

Sandro Santilli <strk>
Project Member
Thu 16 Nov 2006 08:44:52 AM UTC, comment #6:

What i am saying is that when agg isn't installed at all,
configure: error: agg_gradient_lut.h not found, please upgrade to AGG 2.5!
is a bit misleading. Maybe the error message could be changed
to something like

configure: error: agg_gradient_lut.h not found, please install or upgrade to AGG 2.5!

Patrice Dumas <pertusus>
Sat 11 Nov 2006 04:34:02 PM UTC, comment #5:

I'm not sure I understand what you're reqeusting, anyway, do
you mean that the line:

checking for AGG headers... -I/usr/include/agg2

Should instead fail if the agg_gradient_lut.h header is not found ?
I'm of this advice, anyway (should fail)

Sandro Santilli <strk>
Project Member
Sat 11 Nov 2006 02:52:33 PM UTC, comment #4:

When agg-devel is not installed I get:
configure: error: agg_gradient_lut.h not found, please upgrade to AGG 2.5!

When agg, old 2.4 version is installed, I get
checking for AGG headers... -I/usr/include/agg2
configure: error: agg_gradient_lut.h not found, please upgrade to AGG 2.5!

With the newest 2.4 I don't have any error.

It is almos right, but maybe the existence of agg should be
tested before the version?

Patrice Dumas <pertusus>
Sat 11 Nov 2006 12:29:09 AM UTC, comment #3:

Currently the config macros for AGG does look for a header to determine the difference between 2.3 and 2.4. I'd just replace that header with the one you want to use. This code is above the code that egreps the header file in agg.m4.

Rob Savoye <rsavoye>
Project Administrator
Fri 10 Nov 2006 04:50:41 PM UTC, comment #2:

I think it would, yes. There's some code to do something harder then that (look for a templated function inside an existing header)

Sandro Santilli <strk>
Project Member
Fri 10 Nov 2006 04:44:32 PM UTC, comment #1:

Wouldn't it be a solution just to check for "agg_gradient_lut.h" and maybe other specific headers, and if they are not present, then suggest an update?

Tomas Groth <tgc>
Fri 10 Nov 2006 11:49:28 AM UTC, original submission:

The agg version shipped in fedora, for example
agg-devel-2.4-2.1
isn't suitable for gnash since it at least lacks
agg_gradient_lut.h. This comes from the bad habit of
agg maintainer to change tarball without changing
release.

Maybe gnash configure should look for agg-2.5?

Patrice Dumas <pertusus>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 13 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 16 Nov 2006 08:55:19 AM UTCstrkStatusReady For Test=>Fixed
  Open/ClosedOpen=>Closed
Sat 11 Nov 2006 12:47:29 PM UTCnihilusSeverity5 - Blocker=>4 - Important
Sat 11 Nov 2006 12:54:59 AM UTCnihilusStatusIn Progress=>Ready For Test
Fri 10 Nov 2006 12:28:49 PM UTCstrkCategoryNone=>build
  Severity3 - Normal=>5 - Blocker
Fri 10 Nov 2006 12:21:55 PM UTCnihilusCategorybuild=>None
  Severity5 - Blocker=>3 - Normal
  StatusConfirmed=>In Progress
Fri 10 Nov 2006 12:21:54 PM UTCstrkCategoryNone=>build
  Severity3 - Normal=>5 - Blocker
  StatusNone=>Confirmed
  Assigned toNone=>nihilus

Back to the top


Powered by Savane 3.1-cleanup1