bugGnash - The GNU Flash player - Bugs: bug #18186, GTK gui doesn't properly handle...

 
 

bug #18186: GTK gui doesn't properly handle expose events (0.7.2 / head)

Submitted by:  Sandro Santilli <strk>
Submitted on:  Fri 03 Nov 2006 06:05:11 AM UTC  
 
Category: guiSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 02 May 2007 07:57:22 PM UTC, comment #6:

gravity-embedded.swf and other files work now with agg-gtk.
Something must have changed...

Martin Guy <martinwguy>
Sat 04 Nov 2006 12:19:58 AM UTC, comment #5:

Sure, it would also be nice to have a menu item for it (refresh/redraw)

Sandro Santilli <strk>
Project Member
Sat 04 Nov 2006 12:17:07 AM UTC, comment #4:

Looks fine. May I suggest a dedicated GUI function for re-render triggering?

Udo Giacomozzi <udog>
Project Member
Fri 03 Nov 2006 11:07:51 PM UTC, comment #3:

It works fine with opengl renderer (but that might actually be given for free with some automatic backingstore implemented in gtkglext)

Sandro Santilli <strk>
Project Member
Fri 03 Nov 2006 10:31:15 PM UTC, comment #2:

No, but 'expose' event directly call set_invalidated_bounds and then invoke renderBuffer().

Here's the 'expose' event handler:

// Set an invalidate region that contains the entire screen for sure
// TODO: be more conservative in setting draw_bounds
// (look at the GdkEventExpose)
rect draw_bounds(-1e10f, -1e10f, +1e10f, +1e10f);

gui->set_invalidated_region(draw_bounds);

gui->renderBuffer();

Do you see any obvious pitfall ?

Sandro Santilli <strk>
Project Member
Fri 03 Nov 2006 03:13:58 PM UTC, comment #1:

Hmm, is want_redraw() implemented in the GTK gui?

Udo Giacomozzi <udog>
Project Member
Fri 03 Nov 2006 06:05:11 AM UTC, original submission:

Covering the movie window and uncovering it doesn't redraw the exposed parts (unless they move).
Try with gravity-embed.swf, the ball gets redrawn, the buttons don't.

Note that I tested with gtk/agg - am not sure it will still fail
with other renderers.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by martinwguy (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 May 2007 08:02:30 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 02 May 2007 07:57:22 PM UTCmartinwguyStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1