bugGnash - The GNU Flash player - Bugs: bug #18157, klash not automatically disabled...

 
 

bug #18157: klash not automatically disabled when requirements are not met

Submitted by:  None
Submitted on:  Mon 30 Oct 2006 03:25:04 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 03 Nov 2006 09:55:33 AM UTC, comment #25:

This one now works, but the build itself if still broken on some setups, see bug #18170 which should be fixes before release

Tomas Groth <tgc>
Fri 03 Nov 2006 08:46:12 AM UTC, comment #24:

I think the default should be to make the best effor to build every possible thing :)

If you specify --disable-klash on all hosts you'll get
a consistent build.

What we should do, eventually, is to abort from ./configure
IFF an explicit --enable-klash was given...
Anyway, since code in HEAD is already completely different
I suggest we don't make this a show-stopper for 0.7.2

Sandro Santilli <strk>
Project Member
Fri 03 Nov 2006 08:31:35 AM UTC, comment #23:

I am the original reporter and it's working fine now.
However I don't like the fact that some options are enabled only if the relevant libraries are present. I prefer to have the same default for all, if a library is missing it should show an error, or a message saying to use a --disable-flag.
In this way I am sure that compiling the same code with the same options in different machines I get the same feature (e.g.: seems now that kde plugin is enabled if kde is found; I have kde in some machines but I don't want to build the kde plugin). But this is only my personal opinion.

Anonymous
Thu 02 Nov 2006 02:56:53 PM UTC, comment #22:

With no specific flags:

Firefox plugin enabled.
Konqueror plugin disabled (default). Use --enable-plugin and install KDE to build.

.. sounds good to me. Thomas ?

Sandro Santilli <strk>
Project Member
Thu 02 Nov 2006 02:49:18 PM UTC, comment #21:

Ok, clear now.
I just committed a fix to handling of --enable-plugin
and to summary output. Will try again now.

Sandro Santilli <strk>
Project Member
Thu 02 Nov 2006 02:44:52 PM UTC, comment #20:

If you have GTK2 installed, you get the Mozilla plugin. if you have KDE installed, you get klash too. So the default action is to build both plugins if you have the right dependencies installed. If you don't, no KDE leaves out klash, and no GTK leaves out the plugin. If you don't have GTK2, you get forced to SDL, with appropriate warning messages.

I discovered the machines at the SourceForge Compile Farm are very poorly setup, and missing many thing, so they're great for testing configure on.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 02 Nov 2006 02:39:03 PM UTC, comment #19:

mmm, you mean plugin is NOT built unless I have both GTK and KDE ?
So far I was used to build the GTK-based plugin, which would be
nice to do by default even if KDE is not found.

Sandro Santilli <strk>
Project Member
Thu 02 Nov 2006 01:51:43 PM UTC, comment #18:

It's now --disable-plugin, instead of --enable-plugin. I changed this yesterday to build the plugins by default, if possible. If GtkGLExt doesn't exist with OpenGL, you'll now get an error. If GTK or KDE aren't found, the plugin isn't build anymore. This should give the impending release good default behaviour with out any options to configure.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 02 Nov 2006 10:58:03 AM UTC, comment #17:

News from today attemp at ./configure w/out --disable-klash
on the 0.7.2 branch. configure output reports:

Firefox plugin disabled (default). Use --enable-plugin to enable.
Konqueror plugin enabled

But I did specify --enable-plugin (and no 'klash' switches).
Any hint ?

Sandro Santilli <strk>
Project Member
Wed 01 Nov 2006 04:07:16 PM UTC, comment #16:

Can you run configure with "sh -x", and send me the logfile ? Configure may be using the wrong variable to determine if KDE was found.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Wed 01 Nov 2006 01:51:49 PM UTC, comment #15:

still not fixed, it seems (see bug #18170)

Sandro Santilli <strk>
Project Member
Tue 31 Oct 2006 08:22:21 AM UTC, comment #14:

I'm happy you fixed that other problem, anyway what I'm talking about is a missing dependency that isn't detected, or something
like that.

Here's what I see. After configure:

...
Firefox plugin enabled.
Konqueror plugin disabled (default). Use --enable-plugin and install KDE to build.

...
KDE flags are: -I${prefix}/include
KDE libs are: -L${exec_prefix}/lib

As you can see KDE flags are wrong, anyway the konqueror plugin is disabled, so I should have no problem. Still, what happens is
that kde.cpp is still attempted to build ( with no luck, btw )

/usr/lib/ccache/g++ -DHAVE_CONFIG_H -I. -I/home/strk/src/gnash/gnash-0.7.2-bran
ch/gui -I.. -I.. -I/home/strk/src/gnash/gnash-0.7.2-branch -I/home/strk/src/gnas
h/gnash-0.7.2-branch/server -I/home/strk/src/gnash/gnash-0.7.2-branch/server/par
ser -I/home/strk/src/gnash/gnash-0.7.2-branch/libbase -I/home/strk/src/gnash/gna
sh-0.7.2-branch/backend -I/home/strk/src/gnash/gnash-0.7.2-branch/libgeometry -I
/usr/include/SDL -I/extra/glib-2.10.3/include/glib-2.0 -I/extra/glib-2.10.3/lib/
glib-2.0/include -I/usr/include/pango-1.0 -I/extra/glib-2.10.3/include/glib-2.0
-I/extra/glib-2.10.3/lib/glib-2.0/include -I/extra/glib-2.10.3/include/glib-2.0
-I/extra/glib-2.10.3/lib/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include
-I/extra/agg-2.4/include/agg2 -DXTHREADS -I/extra/glib-2.10.3/include/glib-2.0 -
I/extra/glib-2.10.3/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2
.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/extra/gnash-cvs/include/kio -I/extra/gnash-cvs/inclu
de -I/usr/share/qt3/include -I/usr/X11R6/include -I.. -I/home/strk/src/gnash/gna
sh-0.7.2-branch -I/home/strk/src/gnash/gnash-0.7.2-branch/server -I/home/strk/sr
c/gnash/gnash-0.7.2-branch/server/parser -I/home/strk/src/gnash/gnash-0.7.2-bran
ch/libbase -I/home/strk/src/gnash/gnash-0.7.2-branch/backend -I/home/strk/src/gn
ash/gnash-0.7.2-branch/libgeometry -I/usr/include/SDL -I/extra/glib-2.10.3/inclu
de/glib-2.0 -I/extra/glib-2.10.3/lib/glib-2.0/include -I/usr/include/pango-1.0 -
I/extra/glib-2.10.3/include/glib-2.0 -I/extra/glib-2.10.3/lib/glib-2.0/include -
I/extra/glib-2.10.3/include/glib-2.0 -I/extra/glib-2.10.3/lib/glib-2.0/include -
I/usr/include/atk-1.0 -I/usr/include -I/extra/agg-2.4/include/agg2 -DXTHREADS -I
/extra/glib-2.10.3/include/glib-2.0 -I/extra/glib-2.10.3/lib/glib-2.0/include -I
/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/incl
ude/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/extra/gnash-cvs
/include/kio -I/extra/gnash-cvs/include -I/usr/share/qt3/include -I/usr/X11R6/in
clude -DPKGDATADIR=\"/extra/gnash-cvs/share/gnash\" -DQT_THREAD_SUPPORT -D_REENT
RANT -g -O2 -march=pentium4 -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -W
return-type -MT kde.lo -MD -MP -MF .deps/kde.Tpo -c /home/strk/src/gnash/gnash-0
.7.2-branch/gui/kde.cpp -fPIC -DPIC -o .libs/kde.o

...

/home/strk/src/gnash/gnash-0.7.2-branch/gui/kdesup.h:94: error: 'KdeOpenGLGlue'
is used as a type, but is not defined as a type.
/home/strk/src/gnash/gnash-0.7.2-branch/gui/kde.cpp:36:21: klash.moc: No such fi
le or directory

Since use of kde.cpp is triggered by USE_GUI_KDE, I track
the conditional, which goes:

AM_CONDITIONAL(USE_GUI_KDE, test x$gui = xkde -o x$klash = xyes)

Not having given any --disable-klash, the 'klash' variable is set
to 'yes' by default, so USE_GUI_KDE, and USE_GUI_GTK are both set (the latter I explicitly set, because is what I want to build).

All in all it's a good big mess here. I guess the question really
is:

WHAT IS KLASH EXACTLY ?

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 11:06:12 PM UTC, comment #13:

The problem with KDE was simple to find, maybe not so simple to fix. Currently qapp gets initialized with (0, NULL) as a stic variable in kde.cpp. This doesn't work, because QApplication wants argc and argv. Parsing argv gets the -display string from X11, and without it the OpenGL window won't connect correctly.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 30 Oct 2006 05:00:29 PM UTC, comment #12:

the current situation here is that ./configure doesn't show
KDE and doesn't abort (probably because klash is set to no)
still kde is attempted to be built, and build fails.

Ayway, kde.m4 is broken.
I updated ./configure.ac to Print KDE_LDFLAGS and KDE_INCLUDES
iff $kde is "yes" and here's what comes out:

KDE flags are: -I${prefix}/include
KDE libs are: -L${exec_prefix}/lib

These will resolve to gnash prefixes... urgh

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 04:43:03 PM UTC, comment #11:

I believe the kde.m4 macros (which we didn't write) sets these in LIBS, as well as seperate Makefile variables for each. Klash builds the way things are, but it would probably be a good idea to display the proper libraries.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 30 Oct 2006 04:39:53 PM UTC, comment #10:

Actually kde.m4 still needs to be fixed.
I've seen KDE_LDFLAGS is set to the empty string
if libraries are in standard dirs, but I guess there should
at least be some -l flag, right ?
Note that we check against the empty string to see wheter
it was found or not (my last commit), isn't this correct ?

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 04:35:35 PM UTC, comment #9:

The problem with kde.m4 is different. This bug should now be fixed in the release branch. It turned out the KLASH conditional was getting set twice. Now it's not set unless kde is found as well as --enable-plugin is specified. (but not --disable-klash)

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 30 Oct 2006 04:32:41 PM UTC, comment #8:

Actually it seems that kde.m4 is simply broken.

Doesn't properly detect kde on my system, but worst
it reports INCLUDES and LDFLAGS as gnash $libdir and gnash $includedir !!

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 04:27:29 PM UTC, comment #7:

would simply handling this in ./configure by aborting when requirements are not met and suggesting --disable-klash do ?

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 04:09:44 PM UTC, comment #6:

ok, clear now

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 04:05:08 PM UTC, comment #5:

If KDE is not available, then the configure script should disable "klash". If it's not, that's the bug.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 30 Oct 2006 04:03:36 PM UTC, comment #4:

So what if KDE is not available ?

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 03:57:50 PM UTC, comment #3:

No, we need to build klash and gnash at the same time, or we make life very difficult for the folks that package Gnash for the various distributions. Fixing this is one of the main tasks we need to do to get the release out.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 30 Oct 2006 03:55:14 PM UTC, comment #2:

Yep, I wonder if we should make disable-klash the default instead...

Sandro Santilli <strk>
Project Member
Mon 30 Oct 2006 03:35:46 PM UTC, comment #1:

Compiles fine with --disable-klash

Anonymous
Mon 30 Oct 2006 03:25:04 PM UTC, original submission:

I just updated my gnash to current CVS 0.7.2 branch with
./autogen.sh && ./configure && make

and now I get this compile error:

g++ -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -I../server -I../server/parser -I../libbase -I../backend -I../libgeometry -I/usr/include/SDL -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include -I/usr/local/include/gtkglext-1.0 -I/usr/local/lib/gtkglext-1.0/include -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/kio -I.. -I.. -I../server -I../server/parser -I../libbase -I../backend -I../libgeometry -I/usr/include/SDL -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include -I/usr/local/include/gtkglext-1.0 -I/usr/local/lib/gtkglext-1.0/include -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/kio -DPKGDATADIR=\"/usr/local/share/gnash\" -O1 -march=pentium3 -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -MT kde.lo -MD -MP -MF .deps/kde.Tpo -c kde.cpp -fPIC -DPIC -o .libs/kde.o
kde.cpp:36:21: klash.moc: No such file or directory
kde.cpp:45: warning: passing NULL used for non-pointer converting 2 of `
QApplication::QApplication(Display*, long unsigned int, long unsigned int)'
kde.cpp: In member function `virtual void gnash::KdeGui::setTimeout(unsigned
int)':
kde.cpp:135: warning: unused parameter `unsigned int timeout'
kde.cpp: In member function `virtual void
gnash::KdeGui::mouseMoveEvent(QMouseEvent*)':
kde.cpp:283: warning: unused parameter `QMouseEvent*event'
kde.cpp: In member function `virtual void
gnash::KdeGui::mousePressEvent(QMouseEvent*)':
kde.cpp:291: warning: unused parameter `QMouseEvent*event'
kde.cpp: In member function `void gnash::KdeGui::mouseHandle(const QPoint&)':
kde.cpp:300: warning: unused parameter `const QPoint&pos'
/usr/lib/qt/include/qmemarray.h: In member function `QMemArray<type>&
QMemArray<type>::duplicate(const type*, unsigned int) [with type = char]':
/usr/lib/qt/include/qcstring.h:252: instantiated from here
/usr/lib/qt/include/qmemarray.h:85: warning: cast from `const char' to `char'
discards qualifiers from pointer target type
make[3]: *** [kde.lo] Error 1
make[3]: Leaving directory `/home/fabio/sorgenti/gnash/gui'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/fabio/sorgenti/gnash/gui'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/fabio/sorgenti/gnash'
make: *** [all] Error 2

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 03 Nov 2006 09:55:33 AM UTCtgcStatusReady For Test=>Fixed
  Open/ClosedOpen=>Closed
Thu 02 Nov 2006 07:45:28 PM UTCstrkStatusIn Progress=>Ready For Test
Thu 02 Nov 2006 02:56:53 PM UTCstrkCarbon-Copy-=>Added tgc
Wed 01 Nov 2006 01:51:49 PM UTCstrkStatusReady For Test=>In Progress
Mon 30 Oct 2006 04:35:35 PM UTCrsavoyeStatusNone=>Ready For Test
  Assigned toNone=>rsavoye
Mon 30 Oct 2006 04:09:44 PM UTCstrkSummarycompile error in 0.7.2 branch=>klash not automatically disabled when requirements are not met

Back to the top


Powered by Savane 3.1-cleanup1