bugGnash - The GNU Flash player - Bugs: bug #18083, gtk/agg: wrong color...

 
 

bug #18083: gtk/agg: wrong color interpretation ?

Submitted by:  Sandro Santilli <strk>
Submitted on:  Sun 22 Oct 2006 10:36:03 AM UTC  
 
Category: guiSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Hannes Mayr <bik>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 27 Oct 2006 10:32:36 AM UTC, comment #8:

It is fixed for me with latest commit (RGB24)

Sandro Santilli <strk>
Project Member
Fri 27 Oct 2006 10:03:29 AM UTC, comment #7:

Sorry, that was obvious. The buffer is not allocated with the right size for that bit depth. You could set _bpp=24 in GtkAggGlue::init() instead of using gdk_visual_get_best_depth() and that should work without problems.

However, Hannes solved the problem and will check it in soon.

Udo Giacomozzi <udog>
Project Member
Fri 27 Oct 2006 09:55:18 AM UTC, comment #6:

RGB555 - same result
RGB565 - same result
RGB24 - segmentation fault (see below)
RGBA32 - segmentation fault (see below)

[ RGB24 segfault's backtrace ]

#0 0xb7edf524 in gnash::render_handler_agg<agg::pixfmt_alpha_blend_rgb<agg::blender_rgb<agg::rgba8, agg::order_rgb>, agg::row_accessor<unsigned char> > >::begin_display (this=0x809ec90, background_color=
{m_r = 255 '�', m_g = 255 '�', m_b = 255 '�', m_a = 255 '�'},
viewport_width=640, viewport_height=480) at agg_pixfmt_rgb.h:321
#1 0xb7dd6a43 in gnash::render::begin_display (background_color=
{m_r = 255 '�', m_g = 255 '�', m_b = 255 '�', m_a = 255 '�'},
viewport_x0=0, viewport_y0=0, viewport_width=640, viewport_height=480,
x0=0, x1=12800, y0=0, y1=9600)
at /usr/src/gnash/gnash/server/render.cpp:107
#2 0xb7dac5ff in gnash::movie_root::display (this=0x80a0c70)
at /usr/src/gnash/gnash/server/movie_root.cpp:494
#3 0xb7f1ec3e in gnash::Gui::display (this=0x8053278, m=0x80a0c70)
at /usr/src/gnash/gnash/gui/gui.cpp:261
#4 0xb7f1ef24 in gnash::Gui::advance_movie (gui=0x8053278)
at /usr/src/gnash/gnash/gui/gui.cpp:307
#5 0xb6efccf6 in g_source_get_current_time () from /usr/lib/libglib-2.0.so.0
#6 0xb6efc731 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#7 0xb6eff7a6 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#8 0xb6effb67 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#9 0xb731d281 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#10 0xb7f1dc64 in gnash::GtkGui::run (this=0x8053278)
at /usr/src/gnash/gnash/gui/gtk.cpp:290

[ RGBA32 segfault's backtrace ]

#0 0xb7efdcc5 in gnash::render_handler_agg<agg::pixfmt_alpha_blend_rgba<agg::blender_rgba<agg::rgba8, agg::order_rgba>, agg::row_accessor<unsigned char>, unsigned int> >::begin_display (this=0x809ec90, background_color=
{m_r = 255 '�', m_g = 255 '�', m_b = 255 '�', m_a = 255 '�'},
viewport_width=640, viewport_height=480) at agg_pixfmt_rgba.h:1874
#1 0xb7df5a43 in gnash::render::begin_display (background_color=
{m_r = 255 '�', m_g = 255 '�', m_b = 255 '�', m_a = 255 '�'},
viewport_x0=0, viewport_y0=0, viewport_width=640, viewport_height=480,
x0=0, x1=12800, y0=0, y1=9600)
at /usr/src/gnash/gnash/server/render.cpp:107
#2 0xb7dcb5ff in gnash::movie_root::display (this=0x80a0c70)
at /usr/src/gnash/gnash/server/movie_root.cpp:494
#3 0xb7f3dc3e in gnash::Gui::display (this=0x8053278, m=0x80a0c70)
at /usr/src/gnash/gnash/gui/gui.cpp:261
#4 0xb7f3df24 in gnash::Gui::advance_movie (gui=0x8053278)
at /usr/src/gnash/gnash/gui/gui.cpp:307
#5 0xb6f1bcf6 in g_source_get_current_time () from /usr/lib/libglib-2.0.so.0
#6 0xb6f1b731 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#7 0xb6f1e7a6 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#8 0xb6f1eb67 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#9 0xb733c281 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#10 0xb7f3cc64 in gnash::GtkGui::run (this=0x8053278)
at /usr/src/gnash/gnash/gui/gtk.cpp:290

Sandro Santilli <strk>
Project Member
Fri 27 Oct 2006 07:46:40 AM UTC, comment #5:

Try overriding the pixelformat detection. In gtk_glue_agg.cpp force bppformat to one of the following

RGB555
RGB565
RGB24
RGBA32

I'm sure one of these works, please tell me which one...

Udo Giacomozzi <udog>
Project Member
Thu 26 Oct 2006 08:47:06 PM UTC, comment #4:

[lo:gtk-agg]$ gui/gnash -v ../../tests/movies.all/gravity.swf
22:46:14: Verbose output turned on
22:46:14: Created top level window
22:46:14: WARNING: Resize request received while there's still no movie loaded,
can't correctly set movie scale
22:46:14: WARNING: Resize request received while there's still no movie loaded, can't correctly set movie scale
22:46:14: GTK-AGG: Create renderer with pixelformat RGBA16
22:46:14: framebuffer pixel format is RGBA16
22:46:14: Base url set to: file:///usr/src/gnash/tests/movies.all/gravity.swf
22:46:14: GTK-AGG: 620000 bytes offscreen buffer allocated
22:46:14: initialized AGG buffer <0xb6197008>, 620000 bytes, 640x480, rowsize is 1280 bytes

Sandro Santilli <strk>
Project Member
Thu 26 Oct 2006 08:44:19 PM UTC, comment #3:

Not really. But try starting Gnash in verbose mode. I bet it shows 16bpp or at least not 24bpp.

Udo Giacomozzi <udog>
Project Member
Thu 26 Oct 2006 07:44:27 PM UTC, comment #2:

do you know how to tell ? (it's an X session)

Sandro Santilli <strk>
Project Member
Tue 24 Oct 2006 10:28:30 PM UTC, comment #1:

Most probably the wrong pixelformat is used for the renderer. What video mode are you running in?

Udo Giacomozzi <udog>
Project Member
Sun 22 Oct 2006 10:36:03 AM UTC, original submission:

playing gravity.swf with gtk/agg reveals a bug in rendering.
I think not only the colorspace but also the geometry of the
window is wrong. Attached a snapshot.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11027:  gtkagg.png added by strk (186KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 27 Oct 2006 11:04:47 AM UTCstrkStatusWorks For Me=>Fixed
  Assigned toNone=>bik
  Open/ClosedOpen=>Closed
Fri 27 Oct 2006 10:32:36 AM UTCstrkStatusConfirmed=>Works For Me
Fri 27 Oct 2006 09:55:18 AM UTCstrkStatusNone=>Confirmed
Fri 27 Oct 2006 07:46:40 AM UTCudogCarbon-Copy-=>Added -unavailable-
Sun 22 Oct 2006 10:36:03 AM UTCstrkAttached File-=>Added gtkagg.png, #11027

Back to the top


Powered by Savane 3.1-cleanup1