bugGnash - The GNU Flash player - Bugs: bug #18077, --enable-testing breaks the build

 
 

bug #18077: --enable-testing breaks the build

Submitted by:  Jeff Bailey <jbailey>
Submitted on:  Sat 21 Oct 2006 04:28:53 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 07 Jul 2007 12:03:04 PM UTC, comment #6:

--enable-testing no longer exists and I just removed the few unused ENABLE_TESTING ifdefs. CLosing this item.

Martin Guy <martinwguy>
Thu 02 Nov 2006 08:11:48 PM UTC, comment #5:

Yes, I fixed this a few days ago in both the release branch and CVS HEAD. Confirming this would be nice too. :-)

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 02 Nov 2006 07:48:01 PM UTC, comment #4:

Was this fixed lately (I didn't check myself, but I've read something changed on this)

Sandro Santilli <strk>
Project Member
Tue 24 Oct 2006 01:49:26 PM UTC, comment #3:

I'd let Rob decide on this, since he's working on that code...

Sandro Santilli <strk>
Project Member
Sun 22 Oct 2006 12:03:36 PM UTC, comment #2:

Sure - but why the special cased code at all? The functions themselves are small enough and not harmful. It might be easiest to unconditionally include the and still eliminate the --enable-testing option.

I tend not to be a fan of special debug code that even the maintainers aren't using often.

Lemme know, I'll update the patch.

Jeff Bailey <jbailey>
Sun 22 Oct 2006 11:42:51 AM UTC, comment #1:

I'd rather have those include in when ENABLE_TESTING is defined, would that work for you ?

Sandro Santilli <strk>
Project Member
Sat 21 Oct 2006 04:28:53 PM UTC, original submission:

It appears that --enable-testing breaks the build, and that not having it doesn't keep "make check" from running.

The ChangeLog entry:

2006-09-17 Rob Savoye <rob@ute.welcomehome.org>
(...)
* libbase/network.cpp: Fix the warning message about not binding
to a port. Don't include fn_call.h or xml.h.
* libbase/network.h: Don't include fn_call.h or xml.h.

Appears to be the culprit, as the function declarations inside the TESTING guard need it:

network.cpp:void network_geturl(const fn_call& fn)
network.cpp:void network_getprotocol(const fn_call& fn)
network.cpp:void network_gethost(const fn_call& fn)
network.cpp:void network_getport(const fn_call& fn)
network.cpp:void network_getpath(const fn_call& fn)
network.cpp:void network_connected(const fn_call& fn)
network.cpp:void network_getfilefd(const fn_call& fn)
network.cpp:void network_getlistenfd(const fn_call& fn)
network.h:DSOEXPORT void network_geturl(const fn_call& fn);
network.h:DSOEXPORT void network_getprotocol(const fn_call& fn);
network.h:DSOEXPORT void network_gethost(const fn_call& fn);
network.h:DSOEXPORT void network_getport(const fn_call& fn);
network.h:DSOEXPORT void network_getpath(const fn_call& fn);
network.h:DSOEXPORT void network_connected(const fn_call& fn);
network.h:DSOEXPORT void network_getfilefd(const fn_call& fn);
network.h:DSOEXPORT void network_getlistenfd(const fn_call& fn);

Since this can't have worked in over a month, perhaps this is the patch you want:

2006-10-21 Jeff Bailey <jbailey@raspberryginger.com>

* configure.ac: Remove --enable-testing option.
* libbase/network.h: Remove code protected by ENABLE_TESTING.
* libbase/network.cpp: Likewise.
* server/asobj/LocalConnection.cpp: Likewise.
* server/asobj/NetConnection.cpp: Likewise.
* server/impl.cpp: Likewise.
* server/shm.cpp: Likewise.
* server/shm.h: Likewise.
* server/xmlnode.cpp: Likewise.

Jeff Bailey <jbailey>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11015:  gnash-testing.diff added by jbailey (12KiB - text/x-patch - Patch for removal of --enable-testing option.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 07 Jul 2007 12:03:04 PM UTCmartinwguyStatusReady For Test=>Fixed
  Open/ClosedOpen=>Closed
Thu 02 Nov 2006 07:48:01 PM UTCstrkStatusNone=>Ready For Test
Tue 24 Oct 2006 01:49:26 PM UTCstrkAssigned toNone=>rsavoye
Sat 21 Oct 2006 04:28:53 PM UTCjbaileyAttached File-=>Added gnash-testing.diff, #11015

Back to the top


Powered by Savane 3.1-cleanup1