bugGnash - The GNU Flash player - Bugs: bug #17953, zlib configury magic broken

 
 

bug #17953: zlib configury magic broken

Submitted by:  Jeff Bailey <jbailey>
Submitted on:  Mon 09 Oct 2006 03:32:28 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 21 Oct 2006 03:56:14 PM UTC, comment #10:

Looks good, with the following testresults on ppc, compiled on ppc64.

=== Summary ===

make[3]: Rien à faire pour « check-local ».
make[3]: quittant le répertoire « /home/jbailey/Programming/cvstree/gnash/build/testsuite/actionscript.all »
make[2]: quittant le répertoire « /home/jbailey/Programming/cvstree/gnash/build/testsuite/actionscript.all »
../../testsuite/anaylse-results.sh
Test suite ./libbase had these results: 91 passes
Test suite ./actionscript.all had these results:
Test suite ./server had these results: 8 passes

Test Result Totals:
Total passes: 99

Jeff Bailey <jbailey>
Tue 17 Oct 2006 01:52:41 PM UTC, comment #9:

Will do. The Launchpad bzr imports have been stopped for a couple of days due to a bug, but when they're started again I'll be able to update.

Thanks!

Jeff Bailey <jbailey>
Mon 16 Oct 2006 03:24:02 PM UTC, comment #8:

This should be fixed now in CVS. Can you try again ?

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 09 Oct 2006 04:47:02 PM UTC, comment #7:

Actually AC_CHECK_HEADERS and AC_CHECK_LIBS was being used, but incorrectly. I'm fixing it now. This was one of the original mcaros for Gnash, and hasn't been changed since it was created. So you found a bug. :-)

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 09 Oct 2006 04:42:32 PM UTC, comment #6:

The macro should probably ask GCC for a list of library paths to search. But why don't you just use AC_INCLUDE_HEADERS and AC_CHECK_LIBS? It's not obvious why zlib is treated special here.

Jeff Bailey <jbailey>
Mon 09 Oct 2006 04:36:07 PM UTC, comment #5:

Interesting. For YDL on ppc, it seems I'm in a mostly 64bit space. As the graphic driver is hosed for my YDL installtion I was thinking of trying a different distro. I'll have to do this to test, but maybe I can tweak the macro to work better.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 09 Oct 2006 04:30:16 PM UTC, comment #4:

Debian and Ubuntu both do a 32-bit userspace, even for their 64-bit systems. It's not generally considered a win to do 64-bit binaries as they're often bigger for no added value (size on disk, cache misses).

The gcc and everything on the system is all targetted for 32-bit by default. You can even trick it out by running everything under linux32:

jbailey@starshine:~$ uname -a
Linux starshine 2.6.17-10-powerpc64-smp #2 SMP Fri Oct 6 00:09:16 UTC 2006 ppc64 GNU/Linux
jbailey@starshine:~$ linux32 uname -a
Linux starshine 2.6.17-10-powerpc64-smp #2 SMP Fri Oct 6 00:09:16 UTC 2006 ppc GNU/Linux
jbailey@starshine:~$

Also, for the build daemons and such, they are 64-bit systems but use this trick to produce packages that are destined for 32-bit ppc systems.

Jeff Bailey <jbailey>
Mon 09 Oct 2006 04:17:44 PM UTC, comment #3:

I didn't realize anyone on a 64bit ppc system would want to do a 32bit build. What do you do differently to force the 32bit build ? I can potentially trap any condition and then change the test. For most 64bit users, they want the 64 bit libraries over the 32bit ones.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 09 Oct 2006 04:08:45 PM UTC, comment #2:

It adds /usr/lib64 to my path because libz is in there. But I'm doing a 32bit build. It shouldn't be attempting to pull anything in from /usr/lib64 ever. Even if it exists.

Jeff Bailey <jbailey>
Mon 09 Oct 2006 03:54:57 PM UTC, comment #1:

Um, exactly what do you mean by "becomnes wrong" ? I just yesterday build Gnash on a ppc machine running YDL.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 09 Oct 2006 03:32:28 PM UTC, original submission:

I'm on a ppc64 system with a 32bit user space, and this logic becomes wrong:

if test x"${ac_cv_path_zlib_lib}" = x ; then
liblist="${prefix}/lib64 ${prefix}/lib /usr/lib64 /usr/lib /sw/lib /usr/local/lib /home/latest/lib /opt/lib .. ../.."

There are no comments in the code saying why AC_CHECK_LIB and AC_CHECK_HEADER wasn't used.

Jeff Bailey <jbailey>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 21 Oct 2006 03:57:20 PM UTCrsavoyeStatusWorks For Me=>Fixed
  Open/ClosedOpen=>Closed
Mon 09 Oct 2006 03:54:57 PM UTCrsavoyeStatusNone=>Works For Me
  Assigned toNone=>rsavoye

Back to the top


Powered by Savane 3.1-cleanup1