bugPSPP - Bugs: bug #17948, Hex strings don't work

 
 

bug #17948: Hex strings don't work

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 08 Oct 2006 09:43:58 PM UTC  
 
Category: Syntax ParserSeverity: 7 - Major
Status: FixedAssigned to: Ben Pfaff <blp>
Open/Closed: ClosedRelease: Before 0.6.0
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 02 Nov 2006 04:44:31 AM UTC, comment #1:

This was fixed in an earlier check-in.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 08 Oct 2006 09:43:58 PM UTC, original submission:

Hex strings don't work. Here's a patch:

Index: lexer.c
===================================================================
RCS file: /cvsroot/pspp/pspp/src/language/lexer/lexer.c,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 lexer.c
--- lexer.c 8 Jul 2006 03:05:51 -0000 1.7
+++ lexer.c 8 Oct 2006 21:41:48 -0000
@@ -1071,6 +1071,9 @@ convert_numeric_string_to_char_string (e
static int
parse_string (enum string_type type)
{
+ if (type != CHARACTER_STRING)
+ prog++;
+
/* Accumulate the entire string, joining sections indicated by +
signs. */
for (;;)

It's not worth checking in until I've written a test to exercise it, and I'm in the middle of something else.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 02 Nov 2006 04:44:31 AM UTCblpStatusReady for Test/Review=>Fixed
  Open/ClosedOpen=>Closed
Sun 08 Oct 2006 09:44:47 PM UTCblpReleaseNone=>Before 0.6.0

Back to the top


Powered by Savane 3.1-cleanup1