bugGNUstep - Bugs: bug #17735, NSButton sends the action even if...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17735: NSButton sends the action even if mouseUp is outside its frame.

Submitted by:  Enrico Sersale <esersale>
Submitted on:  Thu 14 Sep 2006 10:25:15 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Mon 05 Feb 2007 01:00:51 AM UTC, comment #3:

Now it works as expected.

Enrico Sersale <esersale>
Project Member
Sun 04 Feb 2007 11:55:28 PM UTC, comment #2:

Could you please try if the error still persists with recent versions of GNUstep? My change to the mouse down handling in NSControl has finally been submitted and I expect it to resolve this problem as well.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sun 17 Sep 2006 09:46:45 PM UTC, comment #1:

Could we try to reach a common understanding of this problem first and of how this situation gets handled by OpenStep/Cocoa?

I think that mouse events should mostly be handled by the cell in which they ocure. The control (in this case the button) itself should not do too much by itself.

When the mouse goes up inside the cell the tracking code of the button should deal with that event by sending the corresponding action.

When the mouse goes up within the control but not within the active cell we could either ignore this (what I would prefer) or have the control deal with that.

And finally when the mouse goes up outside the control we should not send any action.

The current code does not check, if the mouse up event happend within the frame bounds. With my proposed new code for mouseDown handling in place the new behaviour would just mean to remove a few more lines of code, which always is great.
But I am feeling a bit reluctant to implement this change in the old version of the code, with which I am not feeling very comfortable.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Thu 14 Sep 2006 10:25:15 AM UTC, original submission:

Click on a button and drag the mouse outside its frame; leave the mouse button.
- expected behaviour: nothing happens.
- actual behaviour: the button sends its action.

Enrico Sersale <esersale>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esersale (Posted a comment)
  • -unavailable- added by FredKiefer (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 Feb 2007 05:13:08 PM UTCFredKieferOpen/ClosedIn Test=>Closed
    Sun 04 Feb 2007 11:55:28 PM UTCFredKieferStatusNone=>Fixed
      Open/ClosedOpen=>In Test
    Sun 17 Sep 2006 09:46:45 PM UTCFredKieferAssigned toNone=>FredKiefer
    Fri 15 Sep 2006 01:42:45 AM UTCgcasaStatusIn Progress=>None
      Assigned togcasa=>None
    Thu 14 Sep 2006 01:38:42 PM UTCgcasaStatusNone=>In Progress
      Assigned toNone=>gcasa

    Back to the top


    Powered by Savane 3.1-cleanup1