bugGNU gv - Bugs: bug #17636, gv fails to honour X resources

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17636: gv fails to honour X resources

Submitted by:  Christoph Berg <myon>
Submitted on:  Thu 07 Sep 2006 11:20:53 AM UTC  
 
Category: Graphical User interfaceSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jose E. Marchesi <jemarch>
Open/Closed: ClosedRelease: 3.6.2

Thu 28 Jun 2007 01:26:08 PM UTC, comment #2:

Fixed in CVS.

Jose E. Marchesi <jemarch>In charge of this item.
Thu 14 Sep 2006 06:57:40 PM UTC, comment #1:

I applied the patch submitted by Bernhard Link. Many thanks!

Jose E. Marchesi <jemarch>In charge of this item.
Thu 07 Sep 2006 11:20:53 AM UTC, original submission:

The following was submitted to Debian bug #148533. I can confirm that the provided patch (by Bernhard Link) fixes the issue.

----------------

Gv first reads the current resources, then overwrites them with the
default values.

As easy test, try:
cat > scales <<EOF
GV.scales: Natural size, 1.200, screen \n\
Pixel based, 1.200, pixel \n\
0.950, 0.950
EOF
xrdb -merge scales
and fire up gv to see it still shows the default menu.

The bug is only a signle True where a False belongs and fixed with the
following patch:

diff -r -u gv-3.6.1/src/main.c gv-patched/src/main.c
--- gv-3.6.1/src/main.c 2004-12-07 00:36:57.000000000 +0100
+++ gv-patched/src/main.c 2006-07-22 14:46:52.450968089 +0200
@@ -607,7 +607,7 @@
XrmDatabase db;
INFMESSAGE(getting resources)
db = resource_buildDatabase(gv_display,gv_class,gv_name,&argc,argv);
- XrmCombineDatabase(db,&gv_database,True);
+ XrmCombineDatabase(db,&gv_database,False);
}

/### initializing widget set and creating application shell #########################/

At this place gv_display are the current resources, while db consists
out of the default resource values. If overwrite is true, the default
ones overwrite the current ones in gv_databases, discarding anything the
user set via xrdb or in his .Xresources...

Christoph Berg <myon>

 

Attached Files
file #10709:  148533_use_Xresources added by myon (571B - application/octet-stream - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jemarch (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Jun 2007 01:26:08 PM UTCjemarchStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Wed 27 Jun 2007 02:00:43 PM UTCjemarchStatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Thu 14 Sep 2006 06:57:40 PM UTCjemarchStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Thu 14 Sep 2006 06:31:02 PM UTCjemarchStatusNone=>In Progress
      Assigned toNone=>jemarch
    Thu 14 Sep 2006 06:22:56 PM UTCjemarchReleaseNone=>3.6.2
    Thu 07 Sep 2006 11:22:11 AM UTCmyonAttached File-=>Added 148533_use_Xresources, #10709

    Back to the top


    Powered by Savane 3.1-cleanup1