bugGnash - The GNU Flash player - Bugs: bug #17616, Plugin opens flash to new tab

 
 

bug #17616: Plugin opens flash to new tab

Submitted by:  Sebastiá Matas <annonygmouse>
Submitted on:  Tue 05 Sep 2006 09:17:43 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 18 Sep 2006 06:29:53 PM UTC, comment #16:

Just for reference, Ming calls this bit "LoadTargetFlag"
It is the 7th bit (value=64)
We should tell this to Alexis, to update its reference.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 18 Sep 2006 06:13:04 PM UTC, comment #15:

Excellent, I'll close this bug then. Let's see the voiptalk.org case now (where no 64 flag is up and we need to resolve the relative url against the current frame url...)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 18 Sep 2006 05:30:11 PM UTC, comment #14:

It works for me!
Thanks!!!

Sebastià

Sebastiá Matas <annonygmouse>
Project Member
Mon 18 Sep 2006 01:48:53 PM UTC, comment #13:

I've committed a patch that takes the method 64 flag into account.
It doesn't seem it's working, but doesn't open new tabs ...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 18 Sep 2006 07:33:12 AM UTC, comment #12:

I've been away for some time. Now that I'm back I see a bit of changes inside CommonGetUrl. I think the changes are wrong in that
an #ifdef forces attach of an external movie. Maybe the method==64 should drive this instead, but still I don't see any use of the 'target' parameter.
I guess your patch won't apply to current code, but I'd also like
to fix the CommonGetUrl function once and definitely.
Sebastia', Could you take a look at current revision and provide
a new patch ? Thanks

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 10 Sep 2006 10:35:53 PM UTC, comment #11:

I attach a trivial patch that starts implementing
what is needed.

I've tried during a couple of hours to write
the code to render the SWF from the URL to the named
placeobject2 but I'm at a loss at how call moviecliploader
or such.

I think the code should be more documented (and I should
learn more C++) for a newbie as me to start implementing
things in gnash.

Maybe someday I'm more inspired I'll be able to implement this...
Regards
Sebastià

Sebastiá Matas <annonygmouse>
Project Member
Sun 10 Sep 2006 07:35:54 PM UTC, comment #10:

ASAIK the t1, t2 etc. are the "names" given to each "canvas" where
the SWF will be rendered (this is what gparser tells me).

If the referenced movie is not an SWF file... no idea. I would
say that we really should expect anything from the URL. Download
a bit of it and then look what it.
But for now, how about looking for .swf and treat it as an SWF?

I'm looking at implementing it... but don't have much hope... :O
I don't find it that simple.

Sebastiá Matas <annonygmouse>
Project Member
Sun 10 Sep 2006 05:06:09 PM UTC, comment #9:

mmm.. the method 64 idea might be a good one.
What about 'target' semantic ? are 't1', 't2' etc movieclip
names ?
What if the referenced movie is not an SWF file ?

Implementing it in this way should be fairly simple by looking
at moviecliploader_loadclip in asobjs/MovieLoader.cpp file.
This would be similar to MovieClip.loadMovie (unimplemented yet)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 10 Sep 2006 08:20:40 AM UTC, comment #8:

I think it's NOT a firefox problem. I'll try to explain it
again.

The flash file: lower_todayscomic.swf tries to LOAD and RENDER
four more flash files INSIDE lower_todayscomic.swf.

The problem is that GNASH doesn't render them INSIDE, instead tries to open a new firefox page to render each of the files
separatedly.

I attach a snapshot of how DOES flash render the lower_todays_comic.swf.

I think that GetUrl2 method (64) should mean to render the
URL INSIDE the parent flash. But I have no idea how to implement
it.

Read my comments #3 and #4 for more information.

Sebastiá Matas <annonygmouse>
Project Member
Sat 09 Sep 2006 10:32:38 PM UTC, comment #7:

It seems that current firefox versions have a broken -remote.
Try running firefox manually and read stderr.
Any call to GetURL should use firefox -remote and google for GetUrl
to find that call is broken :(

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 09 Sep 2006 10:12:48 PM UTC, comment #6:

The DRI is a warning, it means that I don't have 3D acceleration.
The other errors are when gnash tries to open a firefox
window for each of the embedded SWF files in the parent SWF withouth having firefox running.

Can't you replicate the behaviour?
I attach 2 screenshots: one showing firefox after loading
the webpage: http://www.garfield.com/comics/comics_todays.html
and the second one is gnash running "gnash /tmp/lower_todayscomic.swf -v"

Kind regards
Sebastià

Sebastiá Matas <annonygmouse>
Project Member
Sat 09 Sep 2006 09:15:57 PM UTC, comment #5:

I wonder how can you see anything with the DRI error and the "No running window found" one...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 08 Sep 2006 07:06:41 PM UTC, comment #4:

Here's some more info:

jo@portatildebian64:~/gnash$ gnash /tmp/lower_todayscomic.swf -v
21:05:53: Verbose output turned on
21:05:53: OpenGL extension version - 1.2
21:05:53: Got double-buffered visual.
21:05:53: Created top level window
Xlib: extension "XFree86-DRI" missing on display ":0.0".
21:05:54: note: couldn't open cache file 'file:///tmp/lower_todayscomic.swf.gsc'
21:05:54: WARNING: Bogus GetUrl2 method (64) in SWF file, set to 0
21:05:54: get url: target=t1, url=file:///features/BMFs/lower21.swf (../features/BMFs/lower21.swf)
21:05:54: Launching URL... firefox -remote "openurl(file:///features/BMFs/lower21.swf)"
Error: No running window found
21:05:54: WARNING: Bogus GetUrl2 method (64) in SWF file, set to 0
21:05:54: get url: target=t2, url=file:///features/BMFs/lower25.swf (../features/BMFs/lower25.swf)
21:05:54: Launching URL... firefox -remote "openurl(file:///features/BMFs/lower25.swf)"
Error: No running window found
21:05:54: WARNING: Bogus GetUrl2 method (64) in SWF file, set to 0
21:05:54: get url: target=t3, url=file:///features/BMFs/lower13.swf (../features/BMFs/lower13.swf)
21:05:54: Launching URL... firefox -remote "openurl(file:///features/BMFs/lower13.swf)"
Error: No running window found
21:05:55: WARNING: Bogus GetUrl2 method (64) in SWF file, set to 0
21:05:55: get url: target=t4, url=file:///features/BMFs/lower3.swf (../features/BMFs/lower3.swf)
21:05:55: Launching URL... firefox -remote "openurl(file:///features/BMFs/lower3.swf)"
Error: No running window found

Sebastiá Matas <annonygmouse>
Project Member
Fri 08 Sep 2006 07:04:19 PM UTC, comment #3:

I think I didn't explain myself correctly.

What I mean is that it for some strange reason when a SWF is composed of other SWF, it open them in a new tab, instead
of rendering them INSIDE the "father" SWF.

Opening
http://www.garfield.com/comics/comics_todays.html
you'll see that opens 4 more tabs (lower21.swf, lower25.swf, lower13.swf and lower3.swf) and instead of rendering each one
of them INSIDE the lower_todayscomic.swf.

When running lower_todayscomic.swf from command line, it is
rendered incorrectly also (does not show the "sub"SWFs) and
throws the following errors.

jo@portatildebian64:~/gnash$ gnash /tmp/lower_todayscomic.swf
Xlib: extension "XFree86-DRI" missing on display ":0.0".
Error: No running window found
Error: No running window found
Error: No running window found
Error: No running window found

Sebastiá Matas <annonygmouse>
Project Member
Fri 08 Sep 2006 02:09:38 PM UTC, comment #2:

See http://www.mozilla.org/unix/remote.html, it says that openURL(url) should not open a new tab...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 08 Sep 2006 02:01:39 PM UTC, comment #1:

I guess it's Firefox 1.5.6 interpreting the -remote command differently then documented... w/out an arg should use the current tab.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 05 Sep 2006 09:17:43 PM UTC, original submission:

Hi, since some days gnash plugin opens some SWF in new tabs
when it shouldn't.

Examples:
http://www.garfield.com/comics/comics_todays.html
Opens three new tabs.

http://www.pcbox.com
Opens two new pages every two seconds.

Note:
System: Debian unstable (just upgraded)
Browser: Firefox 1.5.6

Kind regards
Sebastià

Sebastiá Matas <annonygmouse>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10728:  todo_loadmovie.diff added by annonygmouse (3KiB - text/plain - Patch to discriminate the different given URL .)
file #10722:  lower_todayscomic_FLASH.png added by annonygmouse (91KiB - image/png - How does FLASH render lower_todayscomic.swf from http://www.garfield.com/comics/comics_todays.html)
file #10721:  instantània2.png added by annonygmouse (20KiB - image/png - gnash running gnash /tmp/lower_todayscomic.swf -v)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 18 Sep 2006 06:13:04 PM UTCstrkStatusNone=>Fixed
  Assigned toNone=>strk
  Open/ClosedOpen=>Closed
Sun 10 Sep 2006 10:35:53 PM UTCannonygmouseAttached File-=>Added todo_loadmovie.diff, #10728
Sun 10 Sep 2006 08:20:40 AM UTCannonygmouseAttached File-=>Added lower_todayscomic_FLASH.png, #10722
Sat 09 Sep 2006 10:13:28 PM UTCannonygmouseAttached File-=>Added instantània2.png, #10721
Sat 09 Sep 2006 10:12:48 PM UTCannonygmouseAttached File-=>Added instantània1.png, #10720

Back to the top


Powered by Savane 3.1-cleanup1