bugGnash - The GNU Flash player - Bugs: bug #17467, cmdline parser failure with...

 
 

bug #17467: cmdline parser failure with "a=b.swf"

Submitted by:  Robert Millan <robertmh>
Submitted on:  Fri 18 Aug 2006 08:03:43 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Aug 2006 06:08:57 AM UTC, comment #3:

nice, thanks!

Anonymous
Tue 22 Aug 2006 12:18:25 AM UTC, comment #2:

I removed the check. We should use getopt style switches to get args, anyway. Unless I'm missing something.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 18 Aug 2006 09:23:44 PM UTC, comment #1:

I think we can safely remove that strchr check.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 18 Aug 2006 08:03:43 PM UTC, original submission:

The command-line parser refuses to add files of the form "a=b.swf", because they collide with variable assignment feature:

// get the file name from the command line
while (optind < argc) {
// Some options set variables, like ip=127.0.0.1
if (strchr(argv[optind], '=')) {
dbglogfile << "Got variable option on command line!" << endl;
} else {
infiles.push_back(argv[optind]);
}
optind++;
}

However, these files are pretty common. Think of, say, "/tmp/fetch.php?file=animation.swf". This file will be generated by the browser/plugin but when gnash is invoked it won't play it.

Robert Millan <robertmh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 22 Aug 2006 08:43:58 PM UTCstrkStatusReady For Test=>Fixed
  Open/ClosedOpen=>Closed
Tue 22 Aug 2006 12:18:25 AM UTCstrkStatusNone=>Ready For Test
  Assigned toNone=>strk

Back to the top


Powered by Savane 3.1-cleanup1