bugmake - Bugs: bug #17381, Compile errors under DJGPP

 
 

bug #17381: Compile errors under DJGPP

Submitted by:  None
Submitted on:  Tue 08 Aug 2006 11:03:14 PM UTC  
 
Severity: 3 - NormalItem Group: Build/Install
Status: FixedPrivacy: Public
Assigned to: Eli Zaretskii <eliz>Open/Closed: Closed
Component Version: 3.81Operating System: MS-DOS
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 12 Jul 2010 07:07:27 PM UTC, comment #3:

The MS-DOS build does not call child_execute_job at all. In Make 3.81, the definition of the function was mistakenly conditioned on _MSDOS_ as well. Now it is only defined on other systems. So this patch is not needed.

I'm closing this report.

Eli Zaretskii <eliz>
Project MemberIn charge of this item.
Mon 12 Jul 2010 06:00:27 PM UTC, comment #2:

Eli: I don't see this patch in the current CVS version. Is this still needed?

Thanks!

Paul D. Smith <psmith>
Project Administrator
Sat 12 Aug 2006 12:48:22 PM UTC, comment #1:

The following patch should take care of this:

2006-08-12 Eli Zaretskii <eliz@gnu.org>

  • job.h [__MSDOS__]: Use the same prototype for child_execute_job as _EMX_ does.

--- job.h~0 2006-02-12 02:16:04.000000000 +0200
+++ job.h 2006-08-12 15:44:06.875000000 +0300
@@ -73,7 +73,7 @@
extern char *construct_command_argv PARAMS ((char line, char *restp, struct file file, char** batch_file));
#ifdef VMS
extern int child_execute_job PARAMS ((char argv, struct child child));
-#elif defined(_EMX_)
+#elif defined(_MSDOS_) || defined(_EMX_)
extern int child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char *argv, char *envp));
#else
extern void child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char *argv, char *envp));

Eli Zaretskii <eliz>
Project MemberIn charge of this item.
Tue 08 Aug 2006 11:03:14 PM UTC, original submission:

Having run sh ./configure the makefile is produced successfully.
However, executing make results in the following error:

job.c:1898: error: conflicting types for 'child_execute_job'
job.h:79: error: previous declaration of 'child_execute_job' was here
job.c: In function 'child_execute_job':
job.c:1931: error: void value not ignored as it ought to be

Entire log attached as text file.

Notably, using exactly the same procedure the v3.80 compiles... but then again there are extra #ifdef conditions in v3.81.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10497:  log.txt added by None (2KiB - text/plain - Make log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by eliz (Posted a comment)
  • -unavailable- added by psmith (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:20:22 AM UTCpsmithFixed Release4.0=>3.82
    Mon 12 Jul 2010 07:59:37 PM UTCpsmithStatusNone=>Fixed
      Fixed ReleaseNone=>4.0
    Mon 12 Jul 2010 07:07:27 PM UTCelizOpen/ClosedOpen=>Closed
      Operating SystemMS Windows=>MS-DOS
    Mon 12 Jul 2010 06:00:27 PM UTCpsmithAssigned toNone=>eliz
    Tue 08 Aug 2006 11:03:14 PM UTCNoneAttached File-=>Added log.txt, #10497

    Back to the top


    Powered by Savane 3.1-cleanup1