bugGNU FreeIPMI - Bugs: bug #17164, simple output based on record type...

 
 

bug #17164: simple output based on record type not sensor type/event type

Submitted by:  Albert Chu <chu11>
Submitted on:  Thu 20 Jul 2006 09:33:43 PM UTC  
 
Category: sensorsSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Balamurugan <balamurugan>Open/Closed: Closed
Operating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 08 Aug 2006 03:30:16 PM UTC, comment #2:

fixed

Albert Chu <chu11>
Project Administrator
Fri 21 Jul 2006 01:08:40 AM UTC, comment #1:

Note that the fixes I've added for the Scheme version of ipmi-sensors is not the correct fix. Sensors output should be based on the event-record-type code from teh start. Output should not be based upon the record type.

Albert Chu <chu11>
Project Administrator
Thu 20 Jul 2006 09:33:43 PM UTC, original submission:

The output of sensors is incorrectly based on the record type instead of the sensor/event type:

(define (sensors-display-simple sdr-record sensor-reading)
(let ((record-type (assoc-ref sdr-record "record_type")))
(cond
((= record-type FI-SDR-FULL-RECORD)
(begin (sensors-display-simple-full-record sdr-record sensor-reading) #t))
((= record-type FI-SDR-COMPACT-RECORD)
(begin (sensors-display-simple-compact-record sdr-record sensor-reading) #t))
((= record-type FI-SDR-EVENT-ONLY-RECORD)
(begin (sensors-display-simple-event-only-record sdr-record sensor-reading) #t))
(else #f))))

A full record type can describe anything, including discrete sensors. Thus the output from ipmi-sensors is invalid. I currently see:

22: Intrusion (Platform Chassis Intrusion): 0.0 unspecified (NA/NA): [General Chassis Intrusion]

B/c this particular sensor had a full sensor record describing the chassis intrusion sensor.

Albert Chu <chu11>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chu11 (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 09 May 2007 06:47:44 AM UTCchu11StatusNone=>Fixed
      Assigned toNone=>balamurugan
    Tue 08 Aug 2006 03:30:16 PM UTCchu11Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1