bugGnash - The GNU Flash player - Bugs: bug #16836, Make fails on sound_handler_mp3.cpp

 
 

bug #16836: Make fails on sound_handler_mp3.cpp

Submitted by:  None
Submitted on:  Tue 13 Jun 2006 09:20:38 AM UTC  
Votes:  100  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 Jun 2006 01:37:22 AM UTC, comment #5:

Ok, I could reproduce it, the namespace issue is confirmed,
but also we had some problems with the old logging code
not yet ported to new architecture.
It's fixed now, although probably useless (no sound is supported)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 19 Jun 2006 12:22:36 AM UTC, comment #4:

Reading the file, I think we just miss to use the 'gnash' namespace. Please try adding:

using namespace gnash;

on top of server/sound_handler_mp3.cpp

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 16 Jun 2006 08:28:32 AM UTC, comment #3:

Same problem here with Mandriva Cooker.

Polaris <pola>
Tue 13 Jun 2006 10:08:25 PM UTC, comment #2:

I added that, but it still doesn't work.

Anonymous
Tue 13 Jun 2006 07:09:31 PM UTC, comment #1:

Try adding '#include "log.h"' at the top of the file, it works for me.

Rob Savoye <rsavoye>
Project Administrator
Tue 13 Jun 2006 09:20:38 AM UTC, original submission:

g++ -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I./swf -I.. -I../libbase -I.. -I/usr/include -I/usr/include/SDL -I/usr/include/SDL -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include/libxml2 -DQT_THREAD_SUPPORT -D_REENTRANT -g -O2 -ansi -Wall -MT sound_handler_mp3.lo -MD -MP -MF .deps/sound_handler_mp3.Tpo -c sound_handler_mp3.cpp -fPIC -DPIC -o .libs/sound_handler_mp3.o
sound_handler_mp3.cpp: In function 'void convert_mp3_data(int16_t*, int, void*, int, int, int, bool)':
sound_handler_mp3.cpp:154: error: 'log_error' was not declared in this scope
sound_handler_mp3.cpp:164: error: expected primary-expression before 'char'
sound_handler_mp3.cpp:165: error: 'parse_frame_info' is not a member of 'mad_helpers'
sound_handler_mp3.cpp:165: error: 'buf' was not declared in this scope
sound_handler_mp3.cpp:167: error: expected primary-expression before ')' token
sound_handler_mp3.cpp:167: error: expected `;' before ')' token
sound_handler_mp3.cpp:181: error: 'log_msg' was not declared in this scope
sound_handler_mp3.cpp:181: error: 'IF_VERBOSE_PARSE' was not declared in this scope
sound_handler_mp3.cpp: At global scope:
sound_handler_mp3.cpp:35: warning: 'const char* mad_helpers::parse_layer(const mad_header*)' defined but not used
sound_handler_mp3.cpp:43: warning: 'const char* mad_helpers::parse_channel_mode(const mad_header*)' defined but not used
sound_handler_mp3.cpp:52: warning: 'const char* mad_helpers::parse_emphasis(const mad_header*)' defined but not used
make[2]: *** [sound_handler_mp3.lo] Error 1
make[2]: Leaving directory `/opt/gnash/server'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/gnash'
make: *** [all] Error 2

It compiles fine without mp3 support. I have libmad0 and libmad0-dev installed. My distro is Ubuntu Dapper AMD64.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10200:  patch added by pola (1KiB - application/octet-stream - Patch that makes it compile, but doesn't really fix anything. Just commenting out the verbose.)
file #10184:  gnash-configure.txt added by None (16KiB - text/plain - configure output)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 100 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 26 Jun 2006 02:04:20 AM UTCstrkOpen/ClosedOpen=>Closed
Mon 19 Jun 2006 01:37:22 AM UTCstrkStatusWorks For Me=>Fixed
  Assigned torsavoye=>strk
Fri 16 Jun 2006 08:50:26 AM UTCpolaAttached File-=>Added patch, #10200
Fri 16 Jun 2006 08:28:32 AM UTCpolaCarbon-Copy-=>Added pola
Tue 13 Jun 2006 07:09:31 PM UTCrsavoyeStatusNone=>Works For Me
  Assigned toNone=>rsavoye
Tue 13 Jun 2006 09:20:38 AM UTCNoneAttached File-=>Added gnash-configure.txt, #10184

Back to the top


Powered by Savane 3.1-cleanup1