bugKawa - Bugs: bug #16660, Additional fix for vertical-bar...

 
 

bug #16660: Additional fix for vertical-bar symbol quoting

Submitted by:  Dean Ferreyra <dferreyra>
Submitted on:  Tue 23 May 2006 01:39:49 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Unexpected resultStatus: Fixed
Privacy: PublicAssigned to: Per Bothner <bothner>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 26 May 2006 05:53:00 AM UTC, comment #2:

Thanks. I checked this in.

Per Bothner <bothner>
Project AdministratorIn charge of this item.
Tue 23 May 2006 01:49:00 AM UTC, comment #1:

By the way, here's how I constructed the regex for DisplayFormat.java:

;; Transcription from R5RS:

(define letter "[a-zA-Z]")
(define digit "[0-9]")
(define special-initial "[!$%&*/:<=>?^_~]")
(define peculiar-identifier "([-+]|[.][.][.])")
(define special-subsequent "([-+.@])")
(define initial
(string-append
"(" letter
"|" special-initial ")"))
(define subsequent
(string-append
"(" initial
"|" digit
"|" special-subsequent ")"))
(define r5rs-identifier
(string-append
"(" initial subsequent "*)"
"|(" peculiar-identifier ")"))

;; R5RS identifiers minus interior colons

(define special-interior "[!$%&*/<=>?^_~]") ;; Note, no colon
(define special-terminator "[:]")
(define interior
(string-append
"(" letter
"|" special-interior
"|" digit
"|" special-subsequent ")"))
(define r5rs-identifier-minus-interior-colons
(string-append
"(" initial interior "*" special-terminator "?)"
"|" peculiar-identifier))

and finally, their values:

#|kawa:41|# r5rs-identifier
(([a-zA-Z]|[!$%&/:<=>?^_~])(([a-zA-Z]|[!$%&/:<=>?^_~])|[0-9]|([-+.@]))*)|(([-+]|[.][.][.]))
#|kawa:42|# r5rs-identifier-minus-interior-colons
(([a-zA-Z]|[!$%&/:<=>?^_~])([a-zA-Z]|[!$%&/<=>?^_~]|[0-9]|([-+.@]))*[:]?)|([-+]|[.][.][.])

Dean Ferreyra <dferreyra>
Tue 23 May 2006 01:39:49 AM UTC, original submission:

We've discovered an additional bug with the vertical-bar quoting patch I submitted.

Here's an example:

#|kawa:243|# (write '|foo,bar|)
foo,bar

This symbol needs some quoting on output, e.g., |foo,bar|. I've attached the patch to fix this.

The bug was that for the character class [+-.@], I should have written, e.g., [-+.@].

Dean Ferreyra <dferreyra>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10035:  symbols-with-vertical-bars5.patch added by dferreyra (657B - application/octet-stream - Fix to properly vertical-bar quote non-R5RS symbols)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 26 May 2006 05:53:00 AM UTCbothnerStatusNone=>Fixed
  Assigned toNone=>bothner
  Open/ClosedOpen=>Closed
Tue 23 May 2006 01:39:49 AM UTCdferreyraAttached File-=>Added symbols-with-vertical-bars5.patch, #10035

Back to the top


Powered by Savane 3.1-cleanup1