bugfindutils - Bugs: bug #16579, select_shell() uses incorrect...

 
 

bug #16579: select_shell() uses incorrect syntax for su

Submitted by:  Andreas Metzler <ametzler>
Submitted on:  Sat 13 May 2006 12:24:46 PM UTC  
 
Category: updatedbSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Chronos TachyonOpen/Closed: Closed
Release: 4.2.27Fixed Release: 4.2.28

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 14 Jun 2006 09:22:05 PM UTC, comment #1:

Fixed in findutils 4.3.x and 4.2.x. The fix will be included in the next releases of each.

James Youngman <jay>
Project AdministratorIn charge of this item.
Sat 13 May 2006 12:24:46 PM UTC, original submission:

Chronos Tachyon writes in http://bugs.debian.org/366269

The select_shell() function in /usr/bin/updatedb has a bug in the way it calls /bin/su; specifically, it attempts 'su "$LOCALUSER" -s $SHELL false', which runs '/bin/bash false', thus attempting to execute /bin/false as a shellscript. (The exit code 126 and error message 'cannot execute binary file' are ignored entirely by updatedb.)

The correct usage of su would be to add "-c" after "-s $SHELL" on lines 87 and 91. This is important if, for instance, the administrator has set $LOCALUSER's shell to /bin/false (which is how I discovered this bug).

----------------------------

Older versions of su as found on Debian (e.g. in sarge) accepted this syntax, but this is consideerd a bug.
cu andreas

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 05 Aug 2006 07:24:13 PM UTCjayOpen/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.2.28
Wed 14 Jun 2006 09:22:05 PM UTCjayStatusNone=>Fixed
  Assigned toNone=>jay

Back to the top


Powered by Savane 3.1-cleanup1