bugGnash - The GNU Flash player - Bugs: bug #16557, [PATCH] Fix library DEPENDs to...

 
 

bug #16557: [PATCH] Fix library DEPENDs to make it possible to build with --as-needed

Submitted by:  None
Submitted on:  Tue 09 May 2006 11:44:09 PM UTC  
Votes:  20  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 11 May 2006 01:23:47 PM UTC, comment #3:

I've committed your latest patch. Thanks!

Bastiaan Jacques <bjacques>
Project Member
Thu 11 May 2006 12:19:51 PM UTC, comment #2:

as-needed is only working when the dependant libraries are also compiled with --as-needed

We have good documentation about what --as-needed is, how it works, what problems can arise and how to fix them at:
http://www.gentoo.org/proj/en/qa/asneeded.xml

the most relevant paragraph is
"Failure in final linking, undefined symbols"

You might be interested in reading it :)

I also attached a new version of the diff.

Stefan Schweizer <genstef>
Thu 11 May 2006 12:08:52 PM UTC, comment #1:

I can compile with -Wl,--as-needed as-is. Why is your patch needed? I also don't see how this linker flag would reveal any bugs, other than showing which linked libraries we don't really need.

You say that some of the internal DEPENDs are wrong, so why does your patch not reference any?

Bastiaan Jacques <bjacques>
Project Member
Tue 09 May 2006 11:44:09 PM UTC, original submission:

Hi,

some of the internal DEPENDs in gnash are wrong and some libraries are missing dependancies.

--as-needed is a special linking parameter which links only what is really needed. It reveals bugs like this :)

I have attached a patch to fix the issue, please have a look at it

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #9942:  gnash-as-needed.diff added by genstef (1KiB - text/x-patch - gnash-as-needed.diff (new version))
file #9935:  gnash-as-needed.diff added by None (839B - text/x-patch - gnash-as-needed.diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 20 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 11 May 2006 01:23:46 PM UTCbjacquesStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Thu 11 May 2006 12:19:51 PM UTCgenstefAttached File-=>Added gnash-as-needed.diff, #9942
Wed 10 May 2006 01:03:01 AM UTCgenstefCarbon-Copy-=>Added -unavailable-
  Carbon-Copy-=>Added genstef
Tue 09 May 2006 11:44:10 PM UTCNoneAttached File-=>Added gnash-as-needed.diff, #9935

Back to the top


Powered by Savane 3.1-cleanup1