bugGNU TeXmacs - Bugs: bug #1622, integer 32 and graphical int...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #1622: integer 32 and graphical int should be different types

Submitted by:  David Allouche <ddaa>
Submitted on:  Wed 06 Nov 2002 09:18:39 AM UTC  
 
Category: NonePriority: 1 - Later
Item Group: CleanupStatus: Need Info
Privacy: PublicAssigned to: Joris van der Hoeven <vdhoeven>
Originator Name: Igor V. KovalenkoOpen/Closed: Closed
Release: Release: 1.0.0.20
Fixed Release: NoneFixed Release: 
Keywords: doxygen SI integer type

Fri 03 Mar 2017 08:27:29 AM UTC, comment #2:

Some context is lacking to properly understand what the debate is about. It related to doxygen but I don't understand the suggestion made in the title.

Presently we have: typedef int SI; which means SI is 32 bits on all platforms for which texmacs is provided. If it were to be enforced more strongly in a different platform it could be defined int32_t. If there are some confusion at places in the code where int is used in place of SI or vice versa, then just fix it there, because a bulk renaming types won't help.

Since this has been open for ~15 years without any more comment, that I don't understand what is asked/suggested, it's maybe time to close it.

Philippe Joyez <pjoyez>
Project Member
Wed 06 Nov 2002 11:20:23 AM UTC, comment #1:

The Right Way to get 32 bits ints is to use the types gint32 and guint32 defined in GLib. If necessary, the relevant parts of GLib might be copied in TeXmacs, but addind a dependence would be cleaner.

David Allouche <ddaa>
Project Administrator
Wed 06 Nov 2002 09:18:39 AM UTC, original submission:

> > This is incorrect.
>
> I don't understand the reason for this being incorrect,
> given this snippet of code from tex_font_rep::draw()
>
> --------------
> SI x= ox;
> int n= N(s);
> int m= n+16;
> SI str[n], buf[m], ker[m];
> for (i=0; i<n; i++) str[i]= ((QN) s[i]);
> tfm->execute (str, n, buf, ker, m);
> --------------
>
> and declaration for execute() in tex.hh
>
> --------------
> void execute (SI* s, int n, SI* buf, SI* ker, int& m);
> --------------
>
> Don't take this as I'm insisting on this change. But there are more places doxygen
> is unable to find a match. I of course can live with this decease :)


Oh, then the error was somewhere else...

In fact, this whole thing is messy, because there should be a distinction
between integers and 32 bits integers. In fact SI was originally supposed
to be the 32 bit integer type. However, after a while, it was rather being
used as the unit for graphics. We probably should

1) Rename SI -> something like "graphical int".
2) Replace int and SI by something like "32 bits integer"
whereever appropriate.
3) Change the configuration file such that "graphical int"
and "32 bits integer" will surely be 32 bits integers
on all architectures.

David Allouche <ddaa>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pjoyez (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 03 Mar 2017 08:27:29 AM UTCpjoyezStatusNone=>Need Info
      Open/ClosedAccepted=>Closed
    Wed 06 Nov 2002 11:28:26 AM UTCddaaOpen/ClosedOpen=>(Error - Not Found)

    Back to the top


    Powered by Savane 3.1-cleanup1