bugGnash - The GNU Flash player - Bugs: bug #16046, Build system bug in DESTDIR...

 
 

bug #16046: Build system bug in DESTDIR support, plugin/Makefile.am (with patch)

Submitted by:  Claudio Fontana <sick_soul>
Submitted on:  Thu 09 Mar 2006 08:18:32 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Mar 2006 03:17:03 PM UTC, comment #1:

The plugin should really only be installed in an existing directory, but maybe not if building a package. So I checked in this patch. I added the mkinstalldirs script as well to be paranoid.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 09 Mar 2006 08:18:32 PM UTC, original submission:

Hello,

trying to use the supported DESTDIR variable:

./configure --prefix=/my/prefix
make
make install DESTDIR=/my/install-destdir

fails because of a bug in plugin/Makefile.am, where
DESTDIR is not considered in the test for .mozilla directory
existance. Also, mkdir is used instead of the correct $(mkinstalldirs).

This patch fixes the issue (also attached - see below).

CLaudio

--- plugin/Makefile.am.~1.15.~ 2006-03-09 20:29:06.000000000 +0100
+++ plugin/Makefile.am 2006-03-09 21:19:56.000000000 +0100
@@ -122,7 +122,7 @@
# installed in the users $(HOME)/.firefox.plugins, the plugin
# won't load due to errors with an undefined MaiAtkObject.
install-pluginLTLIBRARIES: $(plugin_LTLIBRARIES)
- test -d "$(plugindir)" || mkdir "$(DESTDIR)$(plugindir)"
+ test -d "$(DESTDIR)$(plugindir)" || $(mkinstalldirs) "$(DESTDIR)$(plugindir)"
# cp .libs/libgnashplugin.so $(DESTDIR)$(plugindir)/libgnashplugin.so
$(LIBTOOL) --mode=install $(INSTALL) $(INSTALL_STRIP_FLAG) $(plugin_LTLIBRARIES) "$(DESTDIR)$(plugindir)/$(plugin_LTLIBRARIES)"
$(RM) $(DESTDIR)$(plugindir)/libgnashplugin.*a

Claudio Fontana <sick_soul>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1511:  plugin_DESTDIR_fix.udiff added by sick_soul (714B - application/octet-stream - DESTDIR support fix for plugin/Makefile.am)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 10 Mar 2006 03:17:03 PM UTCrsavoyeStatusNone=>Fixed
  Assigned toNone=>rsavoye
  Open/ClosedOpen=>Closed
Thu 09 Mar 2006 08:18:32 PM UTCsick_soulAttached File-=>Added plugin_DESTDIR_fix.udiff, #3485

Back to the top


Powered by Savane 3.1-cleanup1