bugmake - Bugs: bug #15938, functions/foreach test uses...

 
 

bug #15938: functions/foreach test uses non-existent $port_type value

Submitted by:  greg keranen <gkeranen>
Submitted on:  Wed 01 Mar 2006 04:20:11 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.0Operating System: Any
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Mar 2006 12:14:35 AM UTC, comment #1:

I avoided this entire issue by adding my own specific variable to the environment and checking for that rather than using PATH/Path.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Wed 01 Mar 2006 04:20:11 AM UTC, original submission:

--- TEST ENVIRONMENT:
GNU make on CYGWIN_NT-5.1 x2 1.5.19(0.150/4/2) i686
GNU Make 3.81rc1

--- ANALYSIS:
tests/scripts/functions/foreach includes the code:
# On WIN32 systems, the user's path is found in %Path% ($Path)
#
$pathvar = (($port_type eq 'Windows') ? "Path" : "PATH");

'Windows' is not a value that $port_type ever contains.

--- PROPOSED FIX:
$pathvar = (($port_type eq 'W32') ? "Path" : "PATH");

--- PROBLEM WITH PROPOSED FIX - INCOMPATIBLE WITH FIX FOR BUG #15937:

If $port_type eq 'W32' on Cygwin, one of the foreach tests fails.

In Cygwin bash environment only PATH and not Path exists.
QUESTION: Does this same issue apply to MinGW (also identified as 'W32')

functions/foreach ....................................... FAILED (3/4 passed)

--- FILE: work/functions/foreach.diff:

      • work/functions/foreach.base Tue Feb 28 14:19:06 2006

--- work/functions/foreach.log Tue Feb 28 14:19:06 2006
***************

      • 1,2 ****

! undefined file default file environment default file command line override automatic automatic
! foo.o bletch.o null.o @.o garf.o .o .o undefined.o file.o default.o file.o environment.o default.o file.o command.o line.o override.o automatic.o automatic.o
--- 1,2 ----
! undefined file default file undefined default file command line override automatic automatic
! foo.o bletch.o null.o @.o garf.o .o .o undefined.o file.o default.o file.o undefined.o default.o file.o command.o line.o override.o automatic.o automatic.o

greg keranen <gkeranen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1757:  foreach added by gkeranen (2KiB - application/octet-stream - foreach - with proposed fix applied)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:19:45 AM UTCpsmithFixed Release4.0=>3.81
Fri 10 Mar 2006 12:14:35 AM UTCpsmithStatusNone=>Fixed
  Assigned toNone=>psmith
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.0
Wed 01 Mar 2006 04:20:11 AM UTCgkeranenAttached File-=>Added foreach, #3456

Back to the top


Powered by Savane 3.1-cleanup1