bugPSPP - Bugs: bug #15723, HTML driver creates .png files...

 
 

bug #15723: HTML driver creates .png files insecurely

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 12 Feb 2006 05:38:20 PM UTC  
 
Category: Output DriverSeverity: 7 - Major
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 03 Jul 2006 05:40:33 PM UTC, comment #4:

I checked this in and fixed the docs problem you note at the same time.

Ben Pfaff <blp>
Project Administrator
Mon 03 Jul 2006 02:35:44 AM UTC, comment #3:

Looks good to me.

Probably a seperate issue really:
In the texinfo documentation, @code has been used where @file is appropriate.

John Darrington <jmd>
Project Administrator
Sun 02 Jul 2006 12:24:41 AM UTC, comment #2:

The newly attached patch should fix the problem. It makes the location for the PNG files configurable, and by default in the same directory as pspp.html.

Comments?

Ben Pfaff <blp>
Project Administrator
Thu 22 Jun 2006 01:05:23 AM UTC, comment #1:

Further information from Joseph Saint Pierre:

When PSPP is used with device html with "pspp -o html" there is a
file created with the following path: /var/tmp/pspp0.png and the owner
of this file is the user who has sent the command. If this file is
not deleted no one but root cannot use the command "pspp -o html".

Maybe no one else a used PSPP with a multi users environment... I
think this could be simply changed, but unfortunately I dont not how.
I think the created could be located in a directory specific to the
user for example : /var/tmp/$user/pspp0.png to avoid conflict between users.
Another solution could be giving an orignal name based on time or
process number.

John Darrington <jmd>
Project Administrator
Sun 12 Feb 2006 05:38:20 PM UTC, original submission:

The HTML driver creates .png files in /tmp in predictable names without using O_EXCL, so it is a security hole. It should instead use O_EXCL or create them in the same directory as the .html file.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10287:  html.patch added by blp (5KiB - application/octet-stream - proposed fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 03 Jul 2006 05:40:33 PM UTCblpStatusReady for Test/Review=>Fixed
  Open/ClosedOpen=>Closed
Sun 02 Jul 2006 12:50:43 AM UTCblpStatusNone=>Ready for Test/Review
Sun 02 Jul 2006 12:24:42 AM UTCblpAttached File-=>Added html.patch, #10287

Back to the top


Powered by Savane 3.1-cleanup1