bugmake - Bugs: bug #15641, different behavior with jobserver...

 
 

bug #15641: different behavior with jobserver (-j)

Submitted by:  Boris Kolpackov <bosk>
Submitted on:  Mon 06 Feb 2006 08:17:12 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Boris Kolpackov <bosk>Open/Closed: Closed
Component Version: 4.0Operating System: Any
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Feb 2006 05:30:05 PM UTC, comment #2:

Fix is in the repository.

Boris Kolpackov <bosk>
Project MemberIn charge of this item.
Wed 08 Feb 2006 05:13:18 PM UTC, comment #1:

After some debugging it appear that this behavior is due to unhealthy interaction between dontcare inheritance and jobserver logic. In particular, struct child stores pointer to struct file. Later, when the command is completed, the code checks child->file->dontcare to determine whether we need to fail. However, at that point the dontcare flag in struct file instance might already be restored from inherited value to its original value. The fix adds an extra bitfild to the struct child which caches the dontcare flag.

Boris Kolpackov <bosk>
Project MemberIn charge of this item.
Mon 06 Feb 2006 08:17:12 PM UTC, original submission:

$ make
failing to build mod_a.o
building all

$ make -j 2
failing to build mod_a.o
make: *** [mod_a.o] Error 1
make: failing to build mod_b.o

      • Waiting for unfinished jobs....

make: *** [mod_b.o] Error 1

I wonder how come nobody noticed this before. Makefile is attached.

Boris Kolpackov <bosk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2047:  makefile added by bosk (205B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:19:00 AM UTCpsmithFixed Release4.0=>3.81
Wed 08 Feb 2006 05:30:05 PM UTCboskStatusNone=>Fixed
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.0
Wed 08 Feb 2006 05:13:18 PM UTCboskAssigned toNone=>bosk
Mon 06 Feb 2006 08:17:12 PM UTCboskAttached File-=>Added makefile, #3375

Back to the top


Powered by Savane 3.1-cleanup1