bugGnash - The GNU Flash player - Bugs: bug #15523, Chokes on DefineBitsJPEG2 (block...

 
 

bug #15523: Chokes on DefineBitsJPEG2 (block type 21)

Submitted by:  Sandro Santilli <strk>
Submitted on:  Tue 24 Jan 2006 05:30:10 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Apr 2006 02:44:00 PM UTC, comment #3:

As of April 24, this is now fixed in Gnash CVS.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Tue 14 Feb 2006 07:01:27 PM UTC, comment #2:

It turns out this issue is a little bit more complicated than I originally thought. After fixing the error, I found I have another flash file "sugarbowl_1.swf" (attached) that uses the same DefineBitsJPEG2 tag, and it no longer works after the patch. My patch fixes A and breaks B, and reverting the patch breaks A and fixes B. Both files, when broken, choke on an internal libjpeg error (but no doubt it is our fault).

(I should note that the sugarbowl_1.swf I'm attaching doesn't play at all with or without the patch, however with my patch, it crashes on a libjpeg error, and without my patch it crashes somewhere else)

My best guess so far as to the difference between these two files is the flash version - "definebitsjpeg2.swf" is version 7, while "sugarbowl_1.swf" is version 6.

I'm still trying to find out if there might be another reason for the difference, but for the meantime, since I can't see any other reason the jpeg tag would be different in these two files, and since my patch works for the version 7 file, I'm leaving it in.

However, this requires some further investigation.

Michael Carlson <corfe>
Tue 14 Feb 2006 04:27:41 PM UTC, comment #1:

The problem was that the code was trying to load the jpeg header information twice in a row, when a certain constructor was called. I've changed the input_impl struct in jpeg.cpp so that this shouldn't happen again.

Please get latest CVS and confirm this works for you too now.

Michael Carlson <corfe>
Tue 24 Jan 2006 05:30:10 PM UTC, original submission:

A simple jpeg embedded in an swf file results
in a failed assertion.

define_bits_jpeg2_loader: charid = 1 pos = 0x21
gnash: jpeg.cpp:258: void jpeg::jpeg_error_exit(jpeg_common_struct*): Assertion `0' failed.

JPEGTables block type seems to work fine.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1974:  sugarbowl_1.swf added by corfe (31KiB - application/x-shockwave-flash - version 6 definebitsjpeg2 flash file)
file #2127:  definebitsjpeg2.swf added by strk (34KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 24 Apr 2006 02:44:00 PM UTCrsavoyeStatusIn Progress=>Fixed
  Assigned tocorfe=>rsavoye
  Open/ClosedOpen=>Closed
Tue 14 Feb 2006 07:01:27 PM UTCcorfeStatusReady For Test=>In Progress
  Attached File-=>Added sugarbowl_1.swf, #3403
Tue 14 Feb 2006 04:27:41 PM UTCcorfeStatusNone=>Ready For Test
  Assigned toNone=>corfe
Tue 24 Jan 2006 05:30:10 PM UTCstrkAttached File-=>Added definebitsjpeg2.swf, #3309

Back to the top


Powered by Savane 3.1-cleanup1