bugGNU arch -- a revision control system - Bugs: bug #15507, ftp auth does not support ftp...

 
 

bug #15507: ftp auth does not support ftp virtualhost servers

Submitted by:  Guido Serra <zeph>
Submitted on:  Sun 22 Jan 2006 08:50:09 PM UTC  
 
Category: tlaSeverity: 3 - Normal
Item Group: bugStatus: Fixed
Privacy: PublicOpen/Closed: Accepted
Release: 
Fixed Release: tla 1.3.5
Merge Request?: None
Your Archive Name: 
Your Archive Location: 
Assigned to: Andy Tai <atai>

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 07 Feb 2006 12:39:47 PM UTC, comment #2:

you're welcome ;-)

Zeph

Guido Serra <zeph>
Tue 07 Feb 2006 08:45:21 AM UTC, comment #1:

Thanks for the fix.

Andy

Andy Tai <atai>
Project AdministratorIn charge of this item.
Sun 22 Jan 2006 08:50:09 PM UTC, original submission:

i found a bug in libarch/pfs-ftp.c file.
I had to authenticate against a virtualhost ftp server... the ftp account was something like user@domain so the url becames ftp://user@domain:password@server.com/directory

You used str_chr_index() when checking if it's anonymous or not... doing so then you split the string into user and domain:password@server.com. Instead should be user@domain:password and server.com ...

So just change str_chr_index() with str_chr_rindex() ... and it works correctly.

----------------------------------------------------------

narnia:~ zeph$ tla make-archive --mirror -unavailable- ftp://arch@guidoserra.it:PASSWORD@ftp.guidoserra.it/arch
ftp_client_connect: ftp error connecting to guidoserra.it:PASSWORD@ftp.guidoserra.it
0: Unable to connect to server

narnia:~ zeph$ tla-FIXED make-archive --mirror -unavailable- ftp://arch@guidoserra.it:PASSWORD@ftp.guidoserra.it/arch

narnia:~ zeph$ tla-FIXED archives
arch@guidoserra.it-MIRROR
ftp://arch@guidoserra.it:PASSWORD@ftp.guidoserra.it/arch

Guido Serra <zeph>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2150:  pfs-ftp.c added by zeph (57KiB - text/plain - fixed file)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 07 Feb 2006 08:45:21 AM UTCataiFixed Release=>tla 1.3.5
Tue 07 Feb 2006 08:45:20 AM UTCataiStatusNone=>Fixed
  Open/ClosedOpen=>Accepted
Tue 07 Feb 2006 04:29:33 AM UTCataiAssigned toNone=>atai
Sun 22 Jan 2006 08:50:09 PM UTCzephAttached File-=>Added pfs-ftp.c, #3303

Back to the top


Powered by Savane 3.1-cleanup1