bugfindutils - Bugs: bug #15472, Inodes in error message are wrong

 
 

bug #15472: Inodes in error message are wrong

Submitted by:  Eric Blake <ericb>
Submitted on:  Wed 18 Jan 2006 02:22:27 PM UTC  
 
Category:  find Severity:  3 - Normal
Item Group:  Wrong result Status:  Fixed
Privacy:  Public Assigned to:  Eric Blake <ericb>
Originator Name:  Eric Blake Open/Closed:  Closed
Release:  4.2.27 Fixed Release:  4.4.0

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

  Spam posted by anonymous
  Spam posted by anonymous
Sat 08 Mar 2008 10:57:21 AM UTC, comment #7: 

Ping?

James Youngman <jay>
Project Administrator
Sat 17 Nov 2007 12:57:33 PM UTC, comment #6: 

Thanks for the reminder; the existing code is still bogus (printing a 64-bit value converted through a 32-bit specifier on at least cygwin).  But gnulib now provides PRIuMAX (or at least, it provides %ju via the *printf-posix modules), so I've been meaning to revisit this patch to see the best course of action to take with it.

Eric Blake <ericb>
Project AdministratorIn charge of this item.
Sat 17 Nov 2007 12:37:51 PM UTC, comment #5: 

Is the attached patch no longer appropriate?   If it still works, do you still want to apply it?

James Youngman <jay>
Project Administrator
Sat 05 May 2007 10:38:55 AM UTC, comment #4: 

Sorry about the extensive delay in my response.  

Could you go ahead and apply your patch to CVS?   Please remember to apply it both to the 4.2.x branch and the 4.3.x branch (4.3.x is HEAD).   When you've done it, go ahead and mark the bug as fixed but please don't close it until the fix goes into a public release.

James Youngman <jay>
Project Administrator
Tue 14 Mar 2006 06:03:29 PM UTC, comment #3: 

Since gnulib doesn't (yet) provide PRIuMAX, I decided to write the attached patch instead, which uses the inttostr module:

2006-03-14  Eric Blake  <ebb9@byu.net>

  • import-gnulib.sh (findutils_modules): Add inttostr.
  • find/find.c (wd_sanity_check): Use it to avoid truncating inode

in error message; fixes Savannah bug 15472.

Eric Blake <ericb>
Project AdministratorIn charge of this item.
Sat 04 Mar 2006 11:09:07 PM UTC, comment #2: 

(uintmax_t) and "%"PRIuMAX works where (long long) and "%lld" don't, since ino_t cannot be longer than uintmax_t whether or not long long exists.  Gnulib provides a way to detect uintmax_t, and coreutils src/system.h contains an example of defining PRIuMAX correctly on all systems (maybe that should be exported to gnulib).

Eric Blake <ericb>
Project AdministratorIn charge of this item.
Fri 24 Feb 2006 08:08:09 PM UTC, comment #1: 

Point taken, but what about C89 hosts that don't support %lld? 

James Youngman <jay>
Project Administrator
Wed 18 Jan 2006 02:22:27 PM UTC, original submission:  

Someone reported on cygwin that they encountered the following error message from find 4.2.27:

find: //desdata1/divisions/frameworks/share/Tools/BrainTools changed during execution of find (old inode number -411813144, new
inode number -457114904, filesystem type is system) [ref 1114]

However, on cygwin, ino_t is unsigned long long (64 bits, never negative).  The code in wd_sanity_check() that prints values of type ino_t by using %ld on (long)old_ino loses data, and is misleading when a negative number results; it would be better to use %llu on (uintmax_t)old_ino.

Eric Blake <ericb>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #1500:  findutils.patch1 added by ericb (3KiB - text/plain - patch described in comment 3)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ericb (Posted a comment)
  • -email is unavailable- added by jay (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-07 jay Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.4.0
    2008-07-09 jay Attached File#16052 => Removed
    2008-07-09 jay Attached File#16051 => Removed
    2008-07-09 None Attached File- => Added feed_rss10_80x15_2.png, #16051
        Attached File- => Added feed_rss20_80x15.png, #16052
    2008-03-10 ericb StatusIn Progress => Fixed
    2007-05-05 jay StatusNone => In Progress
        Assigned tojay => ericb
    2006-03-14 ericb Attached File- => Added findutils.patch1, #3501
    2006-02-24 jay Assigned toNone => jay

    Back to the top


    Powered by Savane 3.6