bugDotGNU Portable.NET - Bugs: bug #14858, BooleanAnd and BooleanOr swapped...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14858: BooleanAnd and BooleanOr swapped in CodeDom Generators

Submitted by:  None
Submitted on:  Tue 25 Oct 2005 04:34:31 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Tue 25 Oct 2005 11:56:21 PM UTC, comment #1:

fixed in cvs

Deryk Robosson <drobosson>
Project Member
Tue 25 Oct 2005 04:34:31 PM UTC, original submission:

The CodeGeneration for CSharp and VB.NET has the BooleanOr and BooleanAnd value swapped. Specifically the function OutputOperator(CodeBinaryOperatorType op) in both CodeGenerator.cs and VBCodeCompiler.cs.

The original code (as of .72) in CodeGenerator.cs is:

case CodeBinaryOperatorType.BooleanOr:
oper = "&&"; break;
case CodeBinaryOperatorType.BooleanAnd:
oper = "||"; break;

and in VBCodeCompiler.cd is:
case CodeBinaryOperatorType.BooleanOr:
oper = "AndAlso"; break;
case CodeBinaryOperatorType.BooleanAnd:
oper = "OrElse"; break;

CLEARLY these are incorrect.

You can compare the CodeGenerator.cs to the version in the ROTOR project provided by Microsoft at:
http://dotnet.di.unipi.it/Content/sscli/docs/doxygen/fx/bcl/codegenerator_8cs-source.html
which has the correct values.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 25 Oct 2005 11:56:21 PM UTCdrobossonStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1