bugGNUstep - Bugs: bug #14775, NSRulerView displays it's labels...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14775: NSRulerView displays it's labels in vertical mode somewhat incorrectly

Submitted by:  Sašo Kiselkov <diablos>
Submitted on:  Thu 13 Oct 2005 09:38:09 AM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Fri 14 Oct 2005 10:58:49 AM UTC, comment #1:

Fixed in CVS.

Thank you for the patch!

Fred Kiefer <FredKiefer>
Project Member
Thu 13 Oct 2005 09:38:09 AM UTC, original submission:

An NSRulerView displays it's number labels when displaying in vertical mode somewhat incorrectly: their right edge has a constant offset from the left edge of the ruler. This, however, causes problems when the numbers reach large values, such as 1000 or 10000, because the first few digits extend beyond the ruler's left edge and are not visible anymore. As such, the user cannot tell whether what he/she sees is '444', '4444' or something far larger - the first digits simply don't fit anymore. Enlarging the ruler's thickness doesn't help, because of the constant offset.

The problem is located in NSRulerView.m:756:
labelPosition.x = baselineLocation + LABEL_MARK_SIZE + 4 - size.width;

I propose replacing the line with:
labelPosition.x = baselineLocation + _ruleThickness - size.width;

which will make the labels 'aligned to the right', so when making the ruler thicker the label's right edges will stay stuck to the right edge of the ruler, thus allowing larger values to be visible.

Sašo Kiselkov <diablos>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 14 Oct 2005 10:58:49 AM UTCFredKieferOpen/ClosedOpen=>Closed
Fri 14 Oct 2005 10:58:48 AM UTCFredKieferStatusNone=>Fixed

Back to the top


Powered by Savane 3.1-cleanup1