bugfindutils - Bugs: bug #14614, Incorrect C code in findutils...

 
 

bug #14614: Incorrect C code in findutils 4.2.25

Submitted by:  pol tuiu <poltuiu>
Submitted on:  Thu 22 Sep 2005 10:03:28 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: Compilation FailureStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: stephane despretOpen/Closed: Closed
Release: 4.2.26Fixed Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Oct 2005 06:38:39 AM UTC, comment #3:

Oops, I've really checked the fix into CVS now.

James Youngman <jay>
Project AdministratorIn charge of this item.
Mon 03 Oct 2005 11:06:48 PM UTC, comment #2:

Thanks - this should be fixed in CVS now.

James Youngman <jay>
Project AdministratorIn charge of this item.
Thu 22 Sep 2005 01:20:56 PM UTC, comment #1:

The code is valid in C99, but some people are still using C89 compilers, so the fix should be applied.

Also, regexprops.c could use some work, too:

if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib -g2 -Wall -Werror -MT regexprops.o -MD -MP -MF ".deps/regexprops.Tpo" -c -o regexprops.o regexprops.c; \
then mv -f ".deps/regexprops.Tpo" ".deps/regexprops.Po"; else rm -f ".deps/regexprops.Tpo"; exit 1; fi
regexprops.c: In function `describe_regex_syntax':
regexprops.c:434: warning: control reaches end of non-void function
regexprops.c: At top level:
regexprops.c:71: warning: 'table_item' defined but not used
regexprops.c:79: warning: 'code' defined but not used
regexprops.c:106: warning: 'begintable_asis' defined but not used

Eric Blake <ericb>
Project Administrator
Thu 22 Sep 2005 10:03:28 AM UTC, original submission:

There are two minors bugs in findutils : some variables are defined into the body ofthe functions and not in the beginning of the functions.

We are :

  • lib/regextype.c line 148
  • find/find.c line 397

I propose a patch to correct this.

pol tuiu <poltuiu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #3092:  findutils.patch added by poltuiu (917B - application/octet-stream - To correct no-c89 code)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 19 Nov 2005 09:47:43 PM UTCjayOpen/ClosedOpen=>Closed
  Release4.2.25=>4.2.26
Mon 03 Oct 2005 11:06:48 PM UTCjayStatusNone=>Fixed
  Assigned toNone=>jay
Thu 22 Sep 2005 10:03:28 AM UTCpoltuiuAttached File-=>Added findutils.patch, #2985
  Carbon-Copy-=>Added -unavailable-

Back to the top


Powered by Savane 3.1-cleanup1