bugphpGroupWare - Bugs: bug #14612, Last 4 drop-boxes on "Site...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14612: Last 4 drop-boxes on "Site Configuration" page do not save settings (maybe others too).

Submitted by:  Robert <burnttoast>
Submitted on:  Wed 21 Sep 2005 10:54:42 PM UTC  
 
Item Group: 0.9.16.008Category: API - Admin
Severity: 3 - NormalPriority: 1 - Later
Status: FixedPrivacy: Public
Assigned to: Dave Hall <skwashd>Open/Closed: Closed
Component Version: DEBOperating System: GNU/Linux - Debian
Reproducibility: Every TimePlanned Release: None
Fixed Release: 

Sun 04 Dec 2005 05:10:33 AM UTC, comment #4:

Fixed in stable CVS please update

Dave Hall <skwashd>
Project AdministratorIn charge of this item.
Tue 18 Oct 2005 10:49:45 PM UTC, comment #3:

Forgot to mention that I am using Mysql 4.0.

It seems that mysql or something doesnt let you blank a field by submitting your value as ""

(I've heard of similar issues with MySQL / PHP pages before where you have to supply a non null value to a non-null cell. I don't know if MySQL has a special command to make a cell's value null. I also don't know if setting the value to "False" actually has the desired effect with the php code...

Robert <burnttoast>
Wed 21 Sep 2005 11:28:16 PM UTC, comment #2:

select name="newsettings[usecookies]"
option value="False"{lang_No}/option
option value="True"{selected_usecookies_True}{lang_Yes} select

grr... I will post the actuall file next time I attempt to post on here...

Robert <burnttoast>
Wed 21 Sep 2005 11:13:00 PM UTC, comment #1:

ok... It would appear that the posting engine on this page does not comment out items in the post... I will post here the sections again, this time commented out...

I forgot to mention the other three lines... if you change
# <select name="newsettings[usecookies]">
# <option value="">{lang_No}</option>
# <option #value="True"{selected_usecookies_True}>{lang_Yes}</option>
# </select>

to

# <select name="newsettings[usecookies]">
# <option value="False">{lang_No}</option>
# <option #value="True"{selected_usecookies_True}>{lang_Yes}</option>
# </select>
and repeat the procedure for the other three fields that should do it!

Robert <burnttoast>
Wed 21 Sep 2005 10:54:42 PM UTC, original submission:

It would seem that the last four drop boxes on the "Site Configuration" page do not save their settings if they are changed after being selected to "True" or "yes".

Those fields which stick are:

Use cookies to pass sessionid: "Yes"
check ip address of all sessions: "Yes"
Deny all users access to grant other users access to their entries ?: "Yes"
Disable "auto completion" of the login form: "yes"

The problem (from what I can tell) is that in the config.tpl for that page... the value of "No" when it is submitted is "" (nothing). This does not appear to actually change any existing data in my mysql table. If I edit that file and change the "" to "False" and re-use the configuration page everything works fine.

A work around for this (but I'm not sure if it is correct or not) is to change the following file
/path/to/phpgroupware/admin/templates/default/config.tpl

at line: 126, 22nd position in where it reads:

<select name="newsettings[usecookies]">
<option value="">{lang_No}</option>
<option value="True"{selected_usecookies_True}>{lang_Yes}</option>
</select>

to:

<select name="newsettings[usecookies]">
<option value="False">{lang_No}</option>
<option value="True"{selected_usecookies_True}>{lang_Yes}</option>
</select>

Very annoying, also I'm not sure if the proper value for "No" should be (null), False, or No...

Robert <burnttoast>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 04 Dec 2005 05:10:33 AM UTCskwashdAssigned toNone=>skwashd
  Open/ClosedOpen=>Closed
  Carbon-Copy-=>Added -unavailable-
Sun 04 Dec 2005 05:10:32 AM UTCskwashdStatusNone=>Fixed

Back to the top


Powered by Savane 3.1-cleanup1