bugphpGroupWare - Bugs: bug #14271, Missing define in session class

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14271: Missing define in session class

Submitted by:  None
Submitted on:  Wed 24 Aug 2005 01:23:38 PM UTC  
 
Item Group: 0.9.16.005Category: API - phpGroupware API
Severity: 3 - NormalPriority: 5 - Normal
Status: InvalidPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Component Version: SVNOperating System: None
Reproducibility: Every TimePlanned Release: None
Fixed Release: 

Wed 24 Aug 2005 02:08:01 PM UTC, comment #1:

is this actualy a problem (other than causing a NOTICE) or just something you noticed while doing a code review?

First thing, php4 and db are preferences defined in the header manager. db was the original way back in php3, with php4 support the php4 sessions support was added. The inheritance here is an admin pref, not strange at all. DB sessions can still be usefull in a web cluster env if one doens't want to make a custom php4 session handler (no idea why not though).

Second, all that does is call the the php4 only session_id() function and store the php4 session id in a set place in the link when the admin doens't want to use cookies. If the admin has choosen db sessions, this line of code does nothing at all because the php4 session id is irrelevant. I'd agree that it's a sloppy way to do it, but it's not a bug in .16.

I don't think this is a bug for .16, but a design choice that could have been implemented a lot better. If this code remains in the next version it should be fixed, but realy db sessions in phpgw should be depreciated.

Chris Weiss <cw>
Project Administrator
Wed 24 Aug 2005 01:23:38 PM UTC, original submission:

class.sessions.inc.php seems to depend on
class.sessions_php4.inc.php or class.sessions_db.inc.php (really strange inheritance).

Within class.sessions.inc.php a define 'PHPGW_PHPSESSID' (line 1232) is used. But this define will only exist when using sessions_php4, because it will never be defined when using sessions_db.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 24 Aug 2005 02:08:01 PM UTCcwStatusNone=>Invalid
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1