bugmake - Bugs: bug #1418, make -t core dumps

 
 

bug #1418: make -t core dumps

Submitted by:  None
Submitted on:  Mon 14 Oct 2002 11:43:08 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 3.80Operating System: POSIX-Based
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 15 Oct 2002 01:53:53 AM UTC, comment #1:

According to POSIX a target with no commands should not be touched with -t. I implemented a patch for this which fixes the bug.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Mon 14 Oct 2002 11:43:08 PM UTC, original submission:

Given a makefile that starts as the following
===========================
HERE:=$(dir $(word $(words ${MAKEFILE_LIST}),${MAKEFILE_LIST}))

T:=Z$(subst /,_,${HERE})

.PHONEY: $T

ALL+= $T

==============
for Make-3.80rc2, then make -t dumps core. Yes, I know I can not spell '.PHONY', but that is no excuse. The problem occurs in the function 'notice_finished_file', line 790, where it says

for (i = file->cmds->ncommand_lines; i > 0; --i)

just after it has done the 'touch' on the file Zcurrent_dir_with_slash_changed_to_underscore_

At this point, file->cmds is a NULL pointer, so it can not be dereferenced. If I could spell, the line would not be reached, but file->phony is 0 with my spelling mistake.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #109:  remake.c-diff added by psmith (626B - application/octet-stream - Patch to remake.c)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:02:22 AM UTCpsmithFixed Release4.0=>3.81
Tue 15 Oct 2002 01:53:53 AM UTCpsmithFixed ReleaseNone=>(Error - Not Found)
Tue 15 Oct 2002 01:53:52 AM UTCpsmithStatusNone=>(Error - Not Found)
  Assigned toNone=>NA
  Open/ClosedOpen=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1