bugmake - Bugs: bug #13594, Function macro PARAMS not properly...

 
 

bug #13594: Function macro PARAMS not properly defined with Microsoft compiler

Submitted by:  Jerker Bäck <jerker_back>
Submitted on:  Fri 01 Jul 2005 01:34:41 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.0Operating System: MS Windows
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 09 Aug 2005 12:41:48 AM UTC, comment #1:

I fixed this for 3.81 by removing the "&& _STDC_" clause. In the next version of GNU make we won't support pre-ISO compilers any longer anyway.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Fri 01 Jul 2005 01:34:41 AM UTC, original submission:

In make.h(45) the expression

#if defined (_cplusplus) || (defined (__STDC_) && _STDC_)
# undef PARAMS
# define PARAMS(protos) protos
#else /* Not C++ or ANSI C. */
# undef PARAMS
# define PARAMS(protos) ()
#endif /* C++ or ANSI C. */

will not work as desired with Microsoft and Intel compilers since the _STDC_ constant is set to false in normal mode (ANSI C extensions). This will issue:
warning C4113: function-pointer() differs in parameter lists from function-pointer(arg)
at
dir.c(1181)
dir.c(1182)
main.c(970)
main.c(971)
function.c(1141)

solution:
change make.h(45) to
#if defined (__cplusplus) || HAVE_ANSI_COMPILER
or
#if defined (_cplusplus) || (defined (__STDC_) && _STDC_) || defined WINDOWS32

regards Jerker

Jerker Bäck <jerker_back>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:16:52 AM UTCpsmithFixed Release4.0=>3.81
Tue 09 Aug 2005 12:41:48 AM UTCpsmithStatusNone=>Fixed
  Assigned toNone=>psmith
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.0

Back to the top


Powered by Savane 3.1-cleanup1