bugmake - Bugs: bug #13551, type casts on left value in...

 
 

bug #13551: type casts on left value in sub_proc.c

Submitted by:  Jerker Bäck <jerker_back>
Submitted on:  Sun 26 Jun 2005 03:59:40 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.0Operating System: MS Windows
Fixed Release: 3.81Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 Jun 2005 03:59:40 PM UTC, original submission:

make\w32\subproc\sub_proc.c(539) : warning C4213: nonstandard extension used : cast on l-value
it looks like this:
-----------------------------------------
if (pproc->sv_stdin) {
CloseHandle((HANDLE)pproc->sv_stdin[1]);
(HANDLE)pproc->sv_stdin[1] = 0;
}
-----------------------------------------
HANDLE is of type (void*) and should be either NULL or point to a valid created Win32-object (ie a file-handle).

change to:
-----------------------------------------
if (pproc->sv_stdin) {
CloseHandle((HANDLE)pproc->sv_stdin[1]);
pproc->sv_stdin[1] = 0;
}
-----------------------------------------
same at:
make\w32\subproc\sub_proc.c(539)
make\w32\subproc\sub_proc.c(543)
make\w32\subproc\sub_proc.c(547)
make\w32\subproc\sub_proc.c(677)
make\w32\subproc\sub_proc.c(742)
make\w32\subproc\sub_proc.c(750)
make\w32\subproc\sub_proc.c(758)

in resonse to:
make\w32\subproc\sub_proc.c(783) : warning C4701: local variable 'tStdin' may be used without having been initialized

change:
sub_proc.c(661)
HANDLE tStdin, tStdout, tStderr;
to
HANDLE tStdin = NULL, tStdout = NULL, tStderr = NULL;

Jerker Bäck <jerker_back>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 01 Apr 2006 07:16:34 AM UTCpsmithFixed Release4.0=>3.81
Mon 27 Jun 2005 01:06:40 PM UTCpsmithStatusNone=>Fixed
  Assigned toNone=>psmith
  Open/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.0

Back to the top


Powered by Savane 3.1-cleanup1