bugmake - Bugs: bug #13487, my_realloc in glob.c never used

 
 

bug #13487: my_realloc in glob.c never used

Submitted by:  Jerker Bäck <jerker_back>
Submitted on:  Tue 21 Jun 2005 02:17:05 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: Not A BugPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Component Version: 4.0Operating System: Any
Fixed Release: NoneTriage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 21 Jun 2005 01:01:55 PM UTC, comment #1:

It is used, though: the #define redefines realloc() to my_realloc(), and realloc() is used throughout the file. The idea here is to work around non-conformant libc implementations, where realloc(NULL, ...) doesn't behave properly. I'm going to close this particular bug although the issue with Windows is apparently still there.

The glob code is tricky, because it's not technically part of GNU make. We take it from the glibc project and simply include it, verbatim, into GNU make. Any local changes we make to the glob code can cause issues there.

Paul D. Smith <psmith>
Project Administrator
Tue 21 Jun 2005 02:17:05 AM UTC, original submission:

glob.c(194)
error C2373: 'my_realloc' : redefinition; different type modifiers

# ifdef WINDOWS32
static void *
# else
static char *
# endif
my_realloc (p, n)
char *p;
unsigned int n;
{
/* These casts are the for sake of the broken Ultrix compiler,
which warns of illegal pointer combinations otherwise. */
if (p == NULL)
return (char *) malloc (n);
return (char *) realloc (p, n);
}
# define realloc my_realloc

This function is never used

regards Jerker

Jerker Bäck <jerker_back>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 21 Jun 2005 01:01:55 PM UTCpsmithStatusNone=>Not A Bug
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1