bugmake - Bugs: bug #12686, make quietly dies instead of...

 
 

bug #12686: make quietly dies instead of issuing an error

Submitted by:  Boris Kolpackov <bosk>
Submitted on:  Thu 14 Apr 2005 12:32:32 PM UTC  
 
Severity: 4 - ImportantItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Boris Kolpackov <bosk>Open/Closed: Closed
Component Version: 3.81Operating System: Any
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 30 Sep 2009 10:01:06 AM UTC, comment #1:

Fix is in CVS.

Boris Kolpackov <bosk>
Project MemberIn charge of this item.
Thu 14 Apr 2005 12:32:32 PM UTC, original submission:

$ rm bar
$ cat >makefile

all: bar
@echo $@

foo: bar
touch $@

-include foo

$ make || echo failed
failed

$ make -rd
Reading makefiles...
Reading makefile `makefile'...
Reading makefile `foo' (search path) (don't care) (no ~ expansion)...
Updating makefiles....
Considering target file `foo'.
File `foo' does not exist.
Considering target file `bar'.
File `bar' does not exist.
Looking for an implicit rule for `bar'.
No implicit rule found for `bar'.
Finished prerequisites of target file `bar'.
Must remake target `bar'.
Failed to remake target file `bar'.
Finished prerequisites of target file `foo'.
Giving up on target file `foo'.
Considering target file `makefile'.
Looking for an implicit rule for `makefile'.
No implicit rule found for `makefile'.
Finished prerequisites of target file `makefile'.
No need to remake target `makefile'.
Updating goal targets....
Considering target file `all'.
File `all' does not exist.
Pruning file `bar'
Finished prerequisites of target file `all'.
Giving up on target file `all'.

In words the problem lies in the fact that make prunes subgraphs (bar in our case) that may have been built with different dont_care flag (remake.c:update_file, line 295).

There is also a piece of code below (remake.c:update_file_1, line 381) that seem to be dealing with similar (the same?) situation. Should it be duplicated in update_file or maybe moved? It seems to me that file->considered and file->updated have somewhat similar roles.

Paul, any thoughts?

Boris Kolpackov <bosk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Updated the item)
  • -unavailable- added by bosk (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:22:06 AM UTCpsmithFixed Release4.0=>3.82
    Wed 30 Sep 2009 10:01:06 AM UTCboskComponent Version4.0=>3.81
      Fixed ReleaseNone=>4.0
      Open/ClosedOpen=>Closed
      StatusNone=>Fixed
    Mon 09 May 2005 05:14:37 PM UTCboskAssigned toNone=>bosk

    Back to the top


    Powered by Savane 3.1-cleanup1