bugGNUstep - Bugs: bug #12224, Font panel doesn't work well in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12224: Font panel doesn't work well in Gorm

Submitted by:  Quentin Mathé <qmathe>
Submitted on:  Sat 05 Mar 2005 10:03:52 PM UTC  
 
Category: GormSeverity: 2 - Minor
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Gregory John Casamento <gcasa>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 09 Mar 2005 04:36:49 AM UTC, comment #7:

Test successful. Closing.

GJC

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Tue 08 Mar 2005 08:46:16 PM UTC, comment #6:

Thanks a lot Gregory.

It works great now.

Quentin Mathé <qmathe>
Project Member
Tue 08 Mar 2005 05:18:43 AM UTC, comment #5:

Added code to do two things:

1) Properly set the window of the object being edited to key.
2) Added code in a category of NSFontManager to attempt to send the "changeFont:" action to the last edited object, if the responder chain is unsucessful.

Please test this, and let me know if you see any problems. Please add your results here and I will close the bug if it works okay for you.

Thanks for the report.

Later, GJC

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Mon 07 Mar 2005 03:39:26 PM UTC, comment #4:

Thanks for documentation and explanations.

For the "hmm attitude" I'm sorry, I added the "hmm" word to look less harsh in my comment, but it produces the reverse effect I'm just realizing now. :-/

To be more precise now, I'm able to change the fonts in Gorm, when Font panel is not the main window (title bar disabled) and the edited widget is simply selected, however it doesn't work when the Font panel is the main window or the widget text is selected... May be you need more specific feedback ? If the problem is related to -gui, may be I could try to fix it myself ?

Quentin Mathé <qmathe>
Project Member
Mon 07 Mar 2005 01:32:47 AM UTC, comment #3:

I have added the documentation on how it should work to the wiki in the FAQ section and to the same area in the Documentation directory under Gorm.

<i>And I think to document the way it works currently is not the right solution to hmm "correct the problem",</i>

I don't recall ever saying that right solution to "correct the problem" is documentation, simply that it should be documented. I'm simply giving the facts, further I am able to get the desired result 9i.e. changing of the font) when doing exactly what you describe above on my machine. Also, a little less "hmmm attitude" would be nice. That said... read on.

Whether or not changeFont: is called on a given object in a window or not is dictated by the responder chain (please see NSFontManager.m and NSFont.m). If the window is main or key and the widget is selected, then the message will be sent to the right object, if not it won't. I've tested this under MOSX and it seems to work in the same way.

There does seem to be a minor bug in Gorm which prevents this from working when a document is first opened, so the bug could be related to how the main window and first responder statuses get set and when. This is likely the cause of the issue. To get around this, it is necessary to click on the window and click on the widget (as shown in the attached swf) to allow the font panel to change the font.

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Sun 06 Mar 2005 10:26:14 PM UTC, comment #2:

I know it can work when the font panel "isn't on a higher level than the widget's window", I was just arguing this issue doesn't help.
And I think to document the way it works currently is not the right solution to hmm "correct the problem", it should just work intuitively like in Mac OS X Interface Builder (my previous proposal), then no documentation would be needed.

Quentin Mathé <qmathe>
Project Member
Sun 06 Mar 2005 04:38:08 AM UTC, comment #1:

I shall document how to change the font in the Gorm manual both in the Documentation directory and on the mediawiki.

Attached is a snapshot which disproves the assertion that if the font panel "isn't on a higher level than the widget's window" that it won't work.

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Sat 05 Mar 2005 10:03:52 PM UTC, original submission:

GNUstep cvs (Gorm included) 1/03/2005

I know Font panel is usable to change widgets text font… but I'm unable to remember how to do it most of the time (like now ;-). I already talked to Gregory for this problem in the past.

How it should work with text field to take an example :
- you click on your widget to select it or you double-click on it to select widget's text completely
- you choose "Font panel" in "Edit" menu
- you change the selected Font
- you click on "Set" button in "Font panel"
Result : The widget text font has been updated, that's not the case currently in my experience.

There are other problems related to it :
- Font panel isn't on a higher window level than the widget's window (that's not specific to Gorm)
- Widget's text selection is lost when the widget's window isn't key; when you click inside Font panel to take an example

Quentin Mathé <qmathe>
Project Member

 

Attached Files
file #2684:  gorm.swf.bz2 added by gcasa (435KiB - application/x-bzip2 - Font change movie.)
file #2677:  fontchange.jpg added by gcasa (47KiB - image/jpeg - Shows font changed to bold in the button with the font panel below the window.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 09 Mar 2005 04:36:49 AM UTCgcasaOpen/ClosedIn Test=>Closed
Tue 08 Mar 2005 05:18:43 AM UTCgcasaStatusNone=>Fixed
  Open/ClosedOpen=>In Test
Mon 07 Mar 2005 11:53:44 AM UTCgcasaAssigned toNone=>gcasa
Mon 07 Mar 2005 01:42:17 AM UTCgcasaAttached File-=>Added gorm.swf.bz2, #2286
Sun 06 Mar 2005 04:38:08 AM UTCgcasaAttached File-=>Added fontchange.jpg, #2284

Back to the top


Powered by Savane 3.1-cleanup1