bugphpGroupWare - Bugs: bug #12172, adodb - installation using psql...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12172: adodb - installation using psql fails

Submitted by:  Bettina Gille <ceb>
Submitted on:  Mon 28 Feb 2005 02:31:22 PM UTC  
 
Item Group: SVN trunk (dev code)Category: API - Setup
Severity: 4 - ImportantPriority: 7 - High
Status: FixedPrivacy: Public
Assigned to: Philipp Kamps <fipsfuchs>Open/Closed: Closed
Component Version: SVNOperating System: GNU/Linux - Debian
Reproducibility: NonePlanned Release: 0.9.18.000
Fixed Release: 

Thu 03 Mar 2005 05:18:03 PM UTC, comment #2:

I changed following code

include('class.sql_'.$dbms.'inc.php');

to a switch statement.

<smartass>

including files with a variable is a potential security
hole. A switch statement allows you to hardcode the
file, you want to include. It additionally allows you
to react if you choose an unsupported dbms.

</smartass>

Philipp Kamps <fipsfuchs>In charge of this item.
Mon 28 Feb 2005 10:02:59 PM UTC, comment #1:

It needs to changed to 'postgres' ADOdb should never be changed. If we don't hack it, like we did with phplib, then we can easily import from upstream. If mods are needed, extend adodb

Cheers

Dave

Dave Hall <skwashd>
Project Administrator
Mon 28 Feb 2005 02:31:22 PM UTC, original submission:

db_type 'psql' does not work in header.inc.php -> have to use 'postgres' to include the postgres adodb class.
'postgres' does not work for the schema_proc setup classes. either we change the schema_proc class or change the string 'psql' to 'postgres' in the adodb class.

next prob:
Fatal error: Call to a member function on a non-object in /phpgroupware/phpgwapi/inc/class.schema_proc.inc.php on line 441

Bettina Gille <ceb>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 23 Apr 2005 09:13:22 PM UTCcebOpen/ClosedOpen=>Closed
Thu 03 Mar 2005 05:18:03 PM UTCfipsfuchsStatusNone=>Fixed

Back to the top


Powered by Savane 3.1-cleanup1