bugPSPP - Bugs: bug #11955, AGGREGATE crashes on MAX function

 
 

bug #11955: AGGREGATE crashes on MAX function

Submitted by:  John Darrington <jmd>
Submitted on:  Sun 13 Feb 2005 11:52:56 AM UTC  
 
Category: OtherSeverity: 7 - Major
Status: FixedAssigned to: Ben Pfaff <blp>
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 14 Feb 2005 12:24:02 AM UTC, comment #2:

This should now be fixed in CVS. The actual problem, as far as I could tell, was simply a copy from ->format to ->write and ->print that shouldn't have been there at all.

I added a test in tests/bugs for this.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 13 Feb 2005 12:17:39 PM UTC, comment #1:

The attached patch seems to fix the problem, but needs to be checked by a competent authority.

This fix copies the write and print formats from the src variable(s) to the destination variables. But it doesn't really address the situation where there is more than one source variable and they have different formats.

John Darrington <jmd>
Project Administrator
Sun 13 Feb 2005 11:52:56 AM UTC, original submission:

The following input causes pspp to throw an assertion:

DATA LIST LIST
/x (F8.2)
y (a25) .

BEGIN DATA.
87.50 foo
87.34 bar
1 bar
END DATA.

AGGREGATE
/BREAK=y
/x=MAX(x).

LIST /x y.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2545:  patch added by jmd (2KiB - application/octet-stream - Proposed patch.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 14 Feb 2005 12:24:02 AM UTCblpStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Sun 13 Feb 2005 12:17:39 PM UTCjmdSummaryAGREGATE crashes on MAX function=>AGGREGATE crashes on MAX function
  Attached File-=>Added patch, #2188

Back to the top


Powered by Savane 3.1-cleanup1