bugfindutils - Bugs: bug #11715, -xtype and %Y broken

 
 

bug #11715: -xtype and %Y broken

Submitted by:  Andreas Schwab <schwab>
Submitted on:  Mon 24 Jan 2005 01:11:40 PM UTC  
 
Category: findSeverity: 3 - Normal
Item Group: Wrong resultStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Open/Closed: Closed
Release: 4.2.13Fixed Release: 4.2.14

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Jan 2005 04:52:20 PM UTC, comment #1:

Fixed, but rather than adopt the approach above, I made following_links() global to ensure that we handle the case where we are running apply_predicates() on a command-line argument (i.e viz. the distinction between -H and -P).

James Youngman <jay>
Project AdministratorIn charge of this item.
Mon 24 Jan 2005 01:11:40 PM UTC, original submission:

--- find/pred.c
+++ find/pred.c
@@ -841,7 +841,16 @@
{
struct stat sbuf;
int (*ystat) ();
- ystat = options.xstat == lstat ? stat : lstat;
+
+ switch (options.symlink_handling)
+ {
+ case SYMLINK_ALWAYS_DEREF:
+ ystat = optionp_stat;
+ case SYMLINK_DEREF_ARGSONLY:
+ case SYMLINK_NEVER_DEREF:
+ ystat = optionl_stat;
+ }
+
if ((*ystat) (state.rel_pathname, &sbuf) != 0)
{
if ( errno == ENOENT ) {
@@ -1474,10 +1483,10 @@
switch (options.symlink_handling)
{
case SYMLINK_ALWAYS_DEREF:
- ystat = optionl_stat;
+ ystat = optionp_stat;
case SYMLINK_DEREF_ARGSONLY:
case SYMLINK_NEVER_DEREF:
- ystat = optionp_stat;
+ ystat = optionl_stat;
}

if ((*ystat) (state.rel_pathname, &sbuf) != 0)

Andreas Schwab <schwab>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 25 Jan 2005 09:20:33 AM UTCjayOpen/ClosedOpen=>Closed
  Fixed ReleaseNone=>4.2.14
Mon 24 Jan 2005 04:52:20 PM UTCjayStatusNone=>Fixed
  Assigned toNone=>jay

Back to the top


Powered by Savane 3.1-cleanup1